-
-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Transaction#set_context
api
#1947
Conversation
Codecov ReportBase: 98.35% // Head: 98.35% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## neel/otel-expose-finish #1947 +/- ##
===========================================================
- Coverage 98.35% 98.35% -0.01%
===========================================================
Files 151 151
Lines 9380 9404 +24
===========================================================
+ Hits 9226 9249 +23
- Misses 154 155 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also feel like an independent change to me so can base on master
directly.
Can we add test case to clarify the precedence of Scope
and Transaction
's contexts
, likely in sentry_spec.rb
or hub_spec.rb
?
@st0012 regarding the based on master, I'll merge them in order so they'll each get their updated base as master. |
f2d6d71
to
e863e25
Compare
IMO, all of these PRs deserve their own commits on master and independent changlog entries (not under the telemetry one) because 1) they're self-contained and 2) they also affect people who don't use |
I will move the changelog entries, but the history will be clear, I don't want to re-create all these branches. |
7fedc8e
to
9ed5e42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be mixed with other PRs' changes?
e863e25
to
85d1c67
Compare
@st0012 it needed a merge, done now |
contexts
to be set on the transaction directlyTransaction#set_name
api to set name on transaction directlysentry-trace
regex logic intoTransaction.extract_sentry_trace
helper for reusability