Use Sentry.with_child_span
in redis and net/http patches
#1920
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move away from using
span.start_child
explicitly and use the top levelSentry.with_child_span
.This is necessary going forward for having some top-level api control for disabling sentry instrumentation if we're using open telemetry.
Note: I had to remove one net/http test for the unsampled case since that behaviour changed now. But this is fine as in principle the
sampled
flag just controls the finalhub.capture_event
and not the actual span recording.