Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to configure their asset-skipping pattern #1915

Merged
merged 2 commits into from
Oct 9, 2022
Merged

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Oct 9, 2022

Some users have customized asset paths, so the SDK's default pattern may not work for them. In such cases, they can use the new configuration option to set their own path pattern.

Sentry.init do |config|
  config.rails.assets_regexp = /my_regexp/
end

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2022

Codecov Report

Base: 98.45% // Head: 98.45% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (4408ee1) compared to base (b54ba68).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1915   +/-   ##
=======================================
  Coverage   98.45%   98.45%           
=======================================
  Files         151      151           
  Lines        9259     9279   +20     
=======================================
+ Hits         9116     9136   +20     
  Misses        143      143           
Impacted Files Coverage Δ
...entry-rails/lib/sentry/rails/capture_exceptions.rb 100.00% <100.00%> (ø)
sentry-rails/lib/sentry/rails/configuration.rb 100.00% <100.00%> (ø)
sentry-rails/spec/sentry/rails/tracing_spec.rb 99.36% <100.00%> (+0.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@st0012
Copy link
Collaborator Author

st0012 commented Oct 9, 2022

@sl0thentr0py I'll add a changelog before merging it

Some users have customized asset paths, so the SDK's default pattern may
not work for them. In such cases, they can use the new configuration
option to set their own path pattern.

```rb
Sentry.init do |config|
  config.rails.assets_regexp = /my_regexp/
end
```
@st0012 st0012 merged commit d8576d7 into master Oct 9, 2022
@st0012 st0012 deleted the fix-#1913 branch October 9, 2022 15:04
@st0012 st0012 modified the milestones: 6.0.0, 5.6.0 Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants