Replace sentry-ruby-core with sentry-ruby as integration dependency #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sentry-ruby-core was created for loosing version requirement on faraday. It's the actual code container and sentry-ruby just wraps around it with a version requirement. But since faraday is now dropped, this extra structure is not needed anymore. The plan is to make sentry-ruby the gem that holds the logic and point integrations to it. And sentry-ruby-core will just depend on sentry-ruby and does nothing for backward compatibility.
Codecov Report
@@ Coverage Diff @@
## master #1825 +/- ##
=======================================
Coverage 98.47% 98.47%
=======================================
Files 145 145
Lines 8675 8675
=======================================
Hits 8543 8543
Misses 132 132 Continue to review full report at Codecov.
|
This was referenced Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sentry-ruby-corewas created for loosing version requirement on faraday. It's the actual code container andsentry-rubyjust wraps around it with a version requirement. But since faraday is now dropped, this extra structure is not needed anymore.The plan is to make
sentry-rubythe gem that holds the logic and point integrations to it. Andsentry-ruby-corewill just depend onsentry-rubyand does nothing for backward compatibility.Closes #1815