Ignore internal Sidekiq::JobRetry::Skip exception #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1763 +/- ##
==========================================
+ Coverage 98.44% 98.45% +0.01%
==========================================
Files 144 144
Lines 8436 8437 +1
==========================================
+ Hits 8305 8307 +2
+ Misses 131 130 -1
Continue to review full report at Codecov.
|
sl0thentr0py
approved these changes
Mar 18, 2022
danielnolan
added a commit
to danielnolan/honeybadger-ruby
that referenced
this pull request
Oct 24, 2022
* Since upgrading to Honeybadger 5.0 we are getting duplicate errors reported for Sidekiq::JobRetry::Skip and another reported error for the exception that caused the Sidekiq job to be retried. * There was a pr merged to Sentry for a similar issue and Mike Perham said this exception could be ignored. getsentry/sentry-ruby#1763 rails/rails#43625 (comment)
joshuap
pushed a commit
to honeybadger-io/honeybadger-ruby
that referenced
this pull request
Oct 25, 2022
* Since upgrading to Honeybadger 5.0 we are getting duplicate errors reported for Sidekiq::JobRetry::Skip and another reported error for the exception that caused the Sidekiq job to be retried. * There was a pr merged to Sentry for a similar issue and Mike Perham said this exception could be ignored. getsentry/sentry-ruby#1763 rails/rails#43625 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After consulting Sidekiq's author Mike, this exception can be ignored as an adhoc solution to #1731.