Avoid duplicated capturing on the same exception object #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1738 +/- ##
=======================================
Coverage 98.39% 98.39%
=======================================
Files 141 141
Lines 8021 8030 +9
=======================================
+ Hits 7892 7901 +9
Misses 129 129
Continue to review full report at Codecov.
|
st0012
commented
Feb 20, 2022
| @@ -104,7 +106,7 @@ def capture_exception(exception, **options, &block) | |||
|
|
|||
| capture_event(event, **options, &block).tap do | |||
| # mark the exception as captured so we can use this information to avoid duplicated capturing | |||
| exception.instance_variable_set(:@__sentry_captured, true) | |||
| exception.instance_variable_set(Sentry::CAPTURED_SIGNATURE, true) | |||
There was a problem hiding this comment.
I feel like the logic of Sentry.exception_captured? may be used by users or integrations in the future for checking purpose so I extracted it. But marking exception as captured should only be done here so I didn't add a method for it.
sl0thentr0py
approved these changes
Feb 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #1731, the SDK can have duplicated exception report in Rails 7+ applications because of the new
Rails.errorsupport introduced in version5.1.0.After a discussion with the feature author, we decided to let whichever mechanism captures the exception first report it (could be either
Rails.erroror Sentry's integration in different scenarios). Although it's possible that we'd loss some contextual data withRails.error, the difference is acceptable.Also,
sentry-pythonalready has a similar mechanism to de-dup error reports, so it's been proven to work.Fixes #1731