-
-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log Redis command arguments if send_default_pii = true #1726
Conversation
@lewispb Thanks for the work! Again! The PR looks great but I need to do one or two patch releases before merging |
No worries at all @st0012! I just pushed a test case I missed for the span description. |
Codecov Report
@@ Coverage Diff @@
## master #1726 +/- ##
=======================================
Coverage 98.40% 98.41%
=======================================
Files 141 141
Lines 8012 8056 +44
=======================================
+ Hits 7884 7928 +44
Misses 128 128
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the follow up work 👍
Closes #1718
Description
When config.send_default_pii = true we will also log any Redis command arguments