Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directly execute ActionCable's action if the SDK is not initialized #1692

Merged
merged 2 commits into from
Jan 17, 2022

Conversation

st0012
Copy link
Collaborator

@st0012 st0012 commented Jan 17, 2022

Fixes #1691

@st0012 st0012 self-assigned this Jan 17, 2022
@st0012 st0012 added this to the 4.9.2 milestone Jan 17, 2022
@st0012 st0012 changed the title Directly execute the block if the SDK is not initialized Directly execute ActionCable's action if the SDK is not initialized Jan 17, 2022
@st0012 st0012 merged commit bdfa233 into master Jan 17, 2022
@st0012 st0012 deleted the fix-#1691 branch January 17, 2022 16:07
@renchap
Copy link

renchap commented Jan 18, 2022

Thanks for the quick fix, it hit us today with CI failing after a gem update and we spend some time finding out where it came from.

I would suggest a quick release as it can have a wide impact, as many people dont initialise Sentry in their dev or test environments.

@st0012
Copy link
Collaborator Author

st0012 commented Jan 18, 2022

@renchap Thanks for the feedback. I was waiting for a day to see if there're other issues to go along with the release. But it looks like there's not! I'll make the release shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't execute blocks of capture() in tests: doesn't call subscribed from an action cable channel
3 participants