Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor RequestInterface #1673

Merged
merged 4 commits into from
Jan 7, 2022
Merged

Refactor RequestInterface #1673

merged 4 commits into from
Jan 7, 2022

Commits on Jan 7, 2022

  1. Remove redundant clean_env class method

    @st0012
    st0012 committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    8969393 View commit details
    Browse the repository at this point in the history

  2. Duplicating env hash should be RequestInterface's job 

    Since RequestInterface is where the env mutation happens, adding dup
call there makes the whole flow easier to understand and avoids future
misuse of the APIs (e.g. manually initializes the RequestInterface
without first duplicating the env).
    @st0012
    st0012 committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    aeba8b5 View commit details
    Browse the repository at this point in the history

  3. Remove redundant RequestInterface.build

    @st0012
    st0012 committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    6e57143 View commit details
    Browse the repository at this point in the history

  4. Update changelog

    @st0012
    st0012 committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    d8490f3 View commit details
    Browse the repository at this point in the history