Gracefully shutdown background worker before the process exits #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1617 +/- ##
==========================================
- Coverage 98.51% 96.13% -2.38%
==========================================
Files 133 107 -26
Lines 7394 6105 -1289
==========================================
- Hits 7284 5869 -1415
- Misses 110 236 +126
Continue to review full report at Codecov.
|
rhcarvalho
changed the title
sl0thentr0py
approved these changes
Nov 22, 2021
|
@sl0thentr0py np 👍 |
natikgadzhi
reviewed
Nov 4, 2023
| @@ -19,9 +19,7 @@ module Task | |||
| def execute(args=nil) | |||
| return super unless Sentry.initialized? && Sentry.get_current_hub | |||
|
|
|||
| Sentry.get_current_hub.with_background_worker_disabled do | |||
There was a problem hiding this comment.
Looking at execute here — isn't it just not doing anything in this form? Looks like it falls back to super in every branch, no? /cc @st0012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when a process exits, SDK's background worker will discard all WIP sending tasks and cause lost of events. This is why we need to disable background worker in rake integration. And from the discussion in #1612, it seems to cause issues in the resque integration too.
Even though I want to avoid using the
at_exitblock, I don't think the responsibility of shutting down the background worker should fall on users. It should be handled by the SDK whenever possible. So in addition to providing a shutdown API in this PR, the SDK would also start the shutdown procedure when exiting the process.Closes #1612