Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sentry-rails' backtrace_cleanup_callback injection #1510

Merged
merged 3 commits into from
Jul 23, 2021
Merged

Fix sentry-rails' backtrace_cleanup_callback injection #1510

merged 3 commits into from
Jul 23, 2021

Commits on Jul 22, 2021

  1. Remove perform_basic_setup test helper to avoid misuse

    @st0012
    st0012 committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    56ca0d0 View commit details
    Browse the repository at this point in the history

  2. Don't override backtrace_cleanup_callback set by the user 

    `sentry-rails` should check the presence `backtrace_cleanup_callback`
before assigning the default one.

The problem was spotted in #1076 (comment).
    @st0012
    st0012 committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    0edbe8b View commit details
    Browse the repository at this point in the history

  3. Update changelog

    @st0012
    st0012 committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    60cdc6e View commit details
    Browse the repository at this point in the history