Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable release detection when SDK is not configured to send events #1471

Merged
merged 3 commits into from
Jun 11, 2021
Merged

Disable release detection when SDK is not configured to send events #1471

merged 3 commits into from
Jun 11, 2021

Commits on Jun 11, 2021

  1. Move release detection test out of configuration specs

    @st0012
    st0012 committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    f57d8e2 View commit details
    Browse the repository at this point in the history

  2. Detect release "after" SDK config is fully initialized 

    This allows the SDK to log release detection messages with the logger
user provides.
    @st0012
    st0012 committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    f26895a View commit details
    Browse the repository at this point in the history

  3. Don't detect release unless the SDK is ready to send events 

    This makes sure the users don't see release detection warnings when they
don't even plan to use it.

Closes #885
    @st0012
    st0012 committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    891eeeb View commit details
    Browse the repository at this point in the history