Use copied env in events #1186
Merged
Use copied env in events #1186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because Sentry now prepares/sends events in the background, sharing the same env object with the main thread means that the background worker & the main thread could process it at the same time. And since env is essentially a Hash object, this will trigger the ``` RuntimeError: can't add a new key into hash during iteration ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because Sentry now prepares/sends events in the background, sharing the same env object with the main thread means that the background worker & the main thread could process it at the same time. And since env is essentially a Hash object, this will trigger the:
Hopefully, this can fix #1183.
(It's possible that such issues could also be caused by sharing the underlying hash values, like params. But deep-copying the entire env hash could be costly so I want to see if this fix works first.)