Add explanation for order of actions when adding a new SDK / module #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was unclear to me whether the files are needed for pre-releases and when the PR has to be merged in relation to performing the release.
|
At what point should the new module be added to |
marandaneto
reviewed
Nov 30, 2022
Comment on lines
+33
to
+36
| 1. update `.craft.yml` config to publish new package to your registry and GH | ||
| 2. cut the release | ||
| 3. update craft config to publish to release registry | ||
| 4. PR to this repository to manually add published new package. See steps below. |
There was a problem hiding this comment.
The correct order is:
- release without the craft modules (.craft.yml)
- add the released version to the release registry manually
- add the modules to craft modules (.craft.yml)
- enjoy automatic releases
There was a problem hiding this comment.
Thanks, will update later
There was a problem hiding this comment.
There's work in progress to make this easier / unnecessary. So let's wait with this PR.
|
We're moving CI to GHA, please rebase onto |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was unclear to me whether the files are needed for pre-releases and when the PR has to be merged in relation to performing the release.