Skip to content

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Nov 3, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Android E2E feedback test failure

💡 Motivation and Context

Fixes #5326

💚 How did you test it?

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 366.04 ms 409.16 ms 43.12 ms
Size 43.94 MiB 48.81 MiB 4.88 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
93137d1+dirty 367.58 ms 434.94 ms 67.36 ms
4604da9+dirty 292.27 ms 314.16 ms 21.90 ms
3e0a5f9+dirty 379.92 ms 450.96 ms 71.04 ms
88890fe+dirty 328.30 ms 319.85 ms -8.45 ms
f234eb4+dirty 313.23 ms 333.31 ms 20.08 ms
a2bb688+dirty 371.19 ms 389.18 ms 17.99 ms
c7f264b+dirty 356.98 ms 407.46 ms 50.48 ms
a31630c+dirty 359.89 ms 416.90 ms 57.00 ms
bfe454a+dirty 372.42 ms 424.52 ms 52.10 ms
23080e5+dirty 347.29 ms 381.87 ms 34.58 ms

App size

Revision Plain With Sentry Diff
93137d1+dirty 7.15 MiB 8.43 MiB 1.28 MiB
4604da9+dirty 7.15 MiB 8.46 MiB 1.31 MiB
3e0a5f9+dirty 7.15 MiB 8.42 MiB 1.27 MiB
88890fe+dirty 7.15 MiB 8.44 MiB 1.28 MiB
f234eb4+dirty 7.15 MiB 8.46 MiB 1.30 MiB
a2bb688+dirty 7.15 MiB 8.43 MiB 1.28 MiB
c7f264b+dirty 7.15 MiB 8.41 MiB 1.26 MiB
a31630c+dirty 7.15 MiB 8.41 MiB 1.26 MiB
bfe454a+dirty 7.15 MiB 8.42 MiB 1.26 MiB
23080e5+dirty 7.15 MiB 8.41 MiB 1.26 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 425.86 ms 453.82 ms 27.96 ms
Size 43.75 MiB 47.99 MiB 4.23 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c7f264b 434.98 ms 452.96 ms 17.98 ms
d751a5d+dirty 434.24 ms 486.08 ms 51.84 ms
c1573b3 400.85 ms 411.82 ms 10.97 ms
1d62dde+dirty 409.00 ms 453.90 ms 44.90 ms
1e7a472+dirty 348.80 ms 362.55 ms 13.75 ms
c4e097a 338.06 ms 439.36 ms 101.30 ms
3e0a5f9 401.72 ms 394.98 ms -6.74 ms
20d5eaa 377.62 ms 406.50 ms 28.88 ms
a31630c+dirty 408.91 ms 416.80 ms 7.89 ms
59f3a84+dirty 382.16 ms 376.45 ms -5.71 ms

App size

Revision Plain With Sentry Diff
c7f264b 17.75 MiB 19.68 MiB 1.94 MiB
d751a5d+dirty 17.75 MiB 19.68 MiB 1.94 MiB
c1573b3 17.75 MiB 20.15 MiB 2.41 MiB
1d62dde+dirty 17.75 MiB 19.74 MiB 2.00 MiB
1e7a472+dirty 17.75 MiB 19.70 MiB 1.96 MiB
c4e097a 17.75 MiB 19.68 MiB 1.94 MiB
3e0a5f9 17.75 MiB 20.15 MiB 2.41 MiB
20d5eaa 17.75 MiB 20.15 MiB 2.41 MiB
a31630c+dirty 17.75 MiB 19.68 MiB 1.94 MiB
59f3a84+dirty 17.75 MiB 19.70 MiB 1.95 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1207.06 ms 1210.94 ms 3.88 ms
Size 3.41 MiB 4.57 MiB 1.16 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d861c16+dirty 1226.00 ms 1223.35 ms -2.65 ms
49ef936+dirty 1221.27 ms 1221.60 ms 0.34 ms
bc9680d+dirty 1228.57 ms 1233.64 ms 5.07 ms
ba75c7c+dirty 1236.14 ms 1240.69 ms 4.55 ms
5ee3314+dirty 1234.25 ms 1235.44 ms 1.19 ms
f70acbf+dirty 1239.00 ms 1242.53 ms 3.53 ms
b3b5b0d+dirty 1235.16 ms 1238.61 ms 3.45 ms
11ded16+dirty 1220.84 ms 1221.60 ms 0.76 ms
1d62dde+dirty 1204.96 ms 1208.51 ms 3.55 ms
c7f264b+dirty 1229.78 ms 1225.84 ms -3.94 ms

App size

Revision Plain With Sentry Diff
d861c16+dirty 3.19 MiB 4.56 MiB 1.38 MiB
49ef936+dirty 3.19 MiB 4.54 MiB 1.36 MiB
bc9680d+dirty 3.19 MiB 4.38 MiB 1.19 MiB
ba75c7c+dirty 3.19 MiB 4.38 MiB 1.19 MiB
5ee3314+dirty 3.19 MiB 4.55 MiB 1.37 MiB
f70acbf+dirty 3.19 MiB 4.54 MiB 1.36 MiB
b3b5b0d+dirty 3.19 MiB 4.48 MiB 1.29 MiB
11ded16+dirty 3.19 MiB 4.58 MiB 1.39 MiB
1d62dde+dirty 3.19 MiB 4.58 MiB 1.39 MiB
c7f264b+dirty 3.19 MiB 4.48 MiB 1.29 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1221.53 ms 1216.31 ms -5.22 ms
Size 3.41 MiB 4.57 MiB 1.16 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d861c16+dirty 1231.94 ms 1242.32 ms 10.38 ms
49ef936+dirty 1228.42 ms 1217.09 ms -11.33 ms
bc9680d+dirty 1221.41 ms 1241.47 ms 20.06 ms
ba75c7c+dirty 1235.86 ms 1226.45 ms -9.41 ms
5ee3314+dirty 1215.18 ms 1207.64 ms -7.54 ms
f70acbf+dirty 1235.71 ms 1243.14 ms 7.43 ms
b3b5b0d+dirty 1227.71 ms 1239.50 ms 11.79 ms
11ded16+dirty 1230.71 ms 1235.52 ms 4.81 ms
1d62dde+dirty 1214.38 ms 1223.36 ms 8.98 ms
c7f264b+dirty 1211.82 ms 1218.04 ms 6.22 ms

App size

Revision Plain With Sentry Diff
d861c16+dirty 2.63 MiB 4.00 MiB 1.36 MiB
49ef936+dirty 2.63 MiB 3.98 MiB 1.34 MiB
bc9680d+dirty 2.63 MiB 3.81 MiB 1.18 MiB
ba75c7c+dirty 2.63 MiB 3.81 MiB 1.18 MiB
5ee3314+dirty 2.63 MiB 3.99 MiB 1.35 MiB
f70acbf+dirty 2.63 MiB 3.98 MiB 1.34 MiB
b3b5b0d+dirty 2.63 MiB 3.91 MiB 1.28 MiB
11ded16+dirty 2.63 MiB 4.01 MiB 1.38 MiB
1d62dde+dirty 2.63 MiB 4.01 MiB 1.38 MiB
c7f264b+dirty 2.63 MiB 3.91 MiB 1.28 MiB

@antonis antonis marked this pull request as ready for review November 3, 2025 11:45
Copy link
Contributor

@alwx alwx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, thanks for noticing and fixing!

@antonis antonis merged commit 136effd into main Nov 3, 2025
99 of 100 checks passed
@antonis antonis deleted the antonis/feedback-android-e2e branch November 3, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix failing Feedback E2E test

3 participants