Skip to content

Conversation

@lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Oct 13, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Lets automatically log console messages into Sentry Logs when logs are enabled!

💡 Motivation and Context

Completes #5201

💚 How did you test it?

On devices.

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against bdb50ce

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 405.31 ms 399.76 ms -5.55 ms
Size 17.75 MiB 19.70 MiB 1.95 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d916aa3 425.37 ms 427.02 ms 1.65 ms
161947d+dirty 393.26 ms 403.00 ms 9.74 ms
818a608 495.84 ms 498.08 ms 2.25 ms
bc9680d 375.15 ms 401.12 ms 25.97 ms
276d348+dirty 375.48 ms 403.76 ms 28.28 ms
3099014+dirty 439.20 ms 468.40 ms 29.20 ms
95aaf8a 437.89 ms 419.45 ms -18.44 ms
6fee48d+dirty 407.42 ms 437.71 ms 30.29 ms
ba75c7c 367.72 ms 369.16 ms 1.44 ms
93137d1+dirty 400.15 ms 424.74 ms 24.59 ms

App size

Revision Plain With Sentry Diff
d916aa3 17.75 MiB 20.15 MiB 2.41 MiB
161947d+dirty 17.75 MiB 19.70 MiB 1.95 MiB
818a608 17.75 MiB 19.68 MiB 1.94 MiB
bc9680d 17.75 MiB 20.15 MiB 2.41 MiB
276d348+dirty 17.75 MiB 19.69 MiB 1.94 MiB
3099014+dirty 17.75 MiB 19.70 MiB 1.95 MiB
95aaf8a 17.75 MiB 19.68 MiB 1.93 MiB
6fee48d+dirty 17.75 MiB 19.68 MiB 1.94 MiB
ba75c7c 17.75 MiB 20.15 MiB 2.41 MiB
93137d1+dirty 17.75 MiB 19.70 MiB 1.95 MiB

Previous results on branch: lz/console-logs

Startup times

Revision Plain With Sentry Diff
93f4030+dirty 410.10 ms 435.68 ms 25.58 ms

App size

Revision Plain With Sentry Diff
93f4030+dirty 17.75 MiB 19.70 MiB 1.95 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 347.30 ms 390.82 ms 43.51 ms
Size 7.15 MiB 8.43 MiB 1.28 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
161947d+dirty 349.27 ms 435.09 ms 85.82 ms
785ffb1+dirty 380.65 ms 451.83 ms 71.18 ms
af9331b+dirty 374.42 ms 425.68 ms 51.26 ms
276d348+dirty 356.30 ms 405.27 ms 48.97 ms
7be1f99+dirty 369.02 ms 399.60 ms 30.58 ms
3099014+dirty 344.58 ms 404.21 ms 59.63 ms
6fee48d+dirty 370.23 ms 427.86 ms 57.63 ms
93137d1+dirty 367.58 ms 434.94 ms 67.36 ms
a31630c+dirty 359.89 ms 416.90 ms 57.00 ms
2b89ce9+dirty 372.22 ms 417.06 ms 44.84 ms

App size

Revision Plain With Sentry Diff
161947d+dirty 7.15 MiB 8.43 MiB 1.28 MiB
785ffb1+dirty 7.15 MiB 8.42 MiB 1.27 MiB
af9331b+dirty 7.15 MiB 8.41 MiB 1.26 MiB
276d348+dirty 7.15 MiB 8.42 MiB 1.26 MiB
7be1f99+dirty 7.15 MiB 8.42 MiB 1.27 MiB
3099014+dirty 7.15 MiB 8.43 MiB 1.27 MiB
6fee48d+dirty 7.15 MiB 8.41 MiB 1.26 MiB
93137d1+dirty 7.15 MiB 8.43 MiB 1.28 MiB
a31630c+dirty 7.15 MiB 8.41 MiB 1.26 MiB
2b89ce9+dirty 7.15 MiB 8.41 MiB 1.26 MiB

Previous results on branch: lz/console-logs

Startup times

Revision Plain With Sentry Diff
93f4030+dirty 340.36 ms 386.76 ms 46.40 ms

App size

Revision Plain With Sentry Diff
93f4030+dirty 7.15 MiB 8.43 MiB 1.28 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1224.27 ms 1231.00 ms 6.73 ms
Size 2.63 MiB 3.99 MiB 1.36 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d916aa3+dirty 1221.02 ms 1228.98 ms 7.96 ms
a2bb688+dirty 1223.53 ms 1232.90 ms 9.37 ms
3099014+dirty 1226.75 ms 1236.56 ms 9.81 ms
f70acbf+dirty 1235.71 ms 1243.14 ms 7.43 ms
b3b5b0d+dirty 1227.71 ms 1239.50 ms 11.79 ms
c7f264b+dirty 1211.82 ms 1218.04 ms 6.22 ms
bfe454a+dirty 1235.33 ms 1243.12 ms 7.79 ms
46da307+dirty 1217.08 ms 1224.16 ms 7.08 ms
23080e5+dirty 1216.02 ms 1224.94 ms 8.91 ms
21c9e75+dirty 1237.78 ms 1247.66 ms 9.88 ms

App size

Revision Plain With Sentry Diff
d916aa3+dirty 2.63 MiB 3.81 MiB 1.18 MiB
a2bb688+dirty 2.63 MiB 3.99 MiB 1.36 MiB
3099014+dirty 2.63 MiB 3.98 MiB 1.35 MiB
f70acbf+dirty 2.63 MiB 3.98 MiB 1.34 MiB
b3b5b0d+dirty 2.63 MiB 3.91 MiB 1.28 MiB
c7f264b+dirty 2.63 MiB 3.91 MiB 1.28 MiB
bfe454a+dirty 2.63 MiB 3.98 MiB 1.34 MiB
46da307+dirty 2.63 MiB 3.87 MiB 1.24 MiB
23080e5+dirty 2.63 MiB 3.91 MiB 1.28 MiB
21c9e75+dirty 2.63 MiB 3.81 MiB 1.18 MiB

Previous results on branch: lz/console-logs

Startup times

Revision Plain With Sentry Diff
93f4030+dirty 1219.20 ms 1232.56 ms 13.36 ms

App size

Revision Plain With Sentry Diff
93f4030+dirty 2.63 MiB 3.99 MiB 1.36 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1234.14 ms 1239.82 ms 5.67 ms
Size 3.19 MiB 4.56 MiB 1.37 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d916aa3+dirty 1211.02 ms 1221.33 ms 10.31 ms
a2bb688+dirty 1244.82 ms 1238.60 ms -6.22 ms
3099014+dirty 1234.04 ms 1243.22 ms 9.18 ms
f70acbf+dirty 1239.00 ms 1242.53 ms 3.53 ms
b3b5b0d+dirty 1235.16 ms 1238.61 ms 3.45 ms
c7f264b+dirty 1229.78 ms 1225.84 ms -3.94 ms
bfe454a+dirty 1231.82 ms 1239.98 ms 8.16 ms
46da307+dirty 1213.45 ms 1207.96 ms -5.49 ms
23080e5+dirty 1221.39 ms 1222.08 ms 0.70 ms
21c9e75+dirty 1206.20 ms 1223.54 ms 17.35 ms

App size

Revision Plain With Sentry Diff
d916aa3+dirty 3.19 MiB 4.38 MiB 1.19 MiB
a2bb688+dirty 3.19 MiB 4.56 MiB 1.37 MiB
3099014+dirty 3.19 MiB 4.55 MiB 1.36 MiB
f70acbf+dirty 3.19 MiB 4.54 MiB 1.36 MiB
b3b5b0d+dirty 3.19 MiB 4.48 MiB 1.29 MiB
c7f264b+dirty 3.19 MiB 4.48 MiB 1.29 MiB
bfe454a+dirty 3.19 MiB 4.54 MiB 1.36 MiB
46da307+dirty 3.19 MiB 4.44 MiB 1.25 MiB
23080e5+dirty 3.19 MiB 4.48 MiB 1.29 MiB
21c9e75+dirty 3.19 MiB 4.38 MiB 1.19 MiB

Previous results on branch: lz/console-logs

Startup times

Revision Plain With Sentry Diff
93f4030+dirty 1204.19 ms 1220.12 ms 15.93 ms

App size

Revision Plain With Sentry Diff
93f4030+dirty 3.19 MiB 4.56 MiB 1.37 MiB

@lucas-zimerman lucas-zimerman marked this pull request as ready for review October 13, 2025 18:07
Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@antonis antonis merged commit 8e29edf into main Oct 14, 2025
70 of 73 checks passed
@antonis antonis deleted the lz/console-logs branch October 14, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants