Skip to content

Conversation

@alwx
Copy link
Contributor

@alwx alwx commented Aug 7, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

This PR updates the package.json with information about the required versions of node and npm. This makes it easier to set things up.

💡 Motivation and Context

Other JS SDKs and tools (such as https://github.com/getsentry/sentry-javascript or https://github.com/getsentry/sentry-javascript-bundler-plugins) use Volta to manage command-line tools, so there is no reason why sentry-react-native doesn't.

💚 How did you test it?

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

#skip-changelog

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 509896f

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 450.02 ms 432.40 ms -17.62 ms
Size 17.75 MiB 20.15 MiB 2.41 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1247.45 ms 1253.10 ms 5.65 ms
Size 3.19 MiB 4.38 MiB 1.19 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1239.35 ms 1233.00 ms -6.35 ms
Size 2.63 MiB 3.81 MiB 1.18 MiB

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎸
Thank you for improving our workflow @alwx 🥇
I'll leave the final approval/merge top @lucas-zimerman in case he has more feedback or context.

ps. I've added the #skip-changelog tag in the description since this does not directly affect the users of our SDK. This should fix the Dagger check.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 430.11 ms 425.64 ms -4.47 ms
Size 7.15 MiB 8.42 MiB 1.27 MiB

@lucas-zimerman
Copy link
Collaborator

Q: Isn't this going to conflict with the corepack ?

@alwx
Copy link
Contributor Author

alwx commented Aug 8, 2025

@lucas-zimerman how do you think it could conflict?
But volta does support corepack, and it could be installed with volta install corepack

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

Thank you for pointing out, I checked locally and all good.

LGTM!

@lucas-zimerman lucas-zimerman merged commit e06d840 into main Aug 8, 2025
73 checks passed
@lucas-zimerman lucas-zimerman deleted the alwx/volta branch August 8, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants