-
-
Notifications
You must be signed in to change notification settings - Fork 354
feat(workflow): use Volta to simplify the environment setup #5050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Android (legacy) Performance metrics 🚀
|
iOS (new) Performance metrics 🚀
|
iOS (legacy) Performance metrics 🚀
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎸
Thank you for improving our workflow @alwx 🥇
I'll leave the final approval/merge top @lucas-zimerman in case he has more feedback or context.
ps. I've added the #skip-changelog tag in the description since this does not directly affect the users of our SDK. This should fix the Dagger check.
Android (new) Performance metrics 🚀
|
|
Q: Isn't this going to conflict with the corepack ? |
|
@lucas-zimerman how do you think it could conflict? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
Thank you for pointing out, I checked locally and all good.
LGTM!
📢 Type of change
📜 Description
This PR updates the
package.jsonwith information about the required versions ofnodeandnpm. This makes it easier to set things up.💡 Motivation and Context
Other JS SDKs and tools (such as https://github.com/getsentry/sentry-javascript or https://github.com/getsentry/sentry-javascript-bundler-plugins) use Volta to manage command-line tools, so there is no reason why
sentry-react-nativedoesn't.💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled#skip-changelog