Skip to content

chore(deps): Support RN 0.80.0 #4938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 24, 2025
Merged

chore(deps): Support RN 0.80.0 #4938

merged 8 commits into from
Jun 24, 2025

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Jun 18, 2025 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

  • Removes folly_flags on iOS for RN >= 0.80 (ref)
  • Adds codegen step on Android E2E test app (ref)
  • Bumps e2e test to RN 0.80.0

💡 Motivation and Context

Fixes #4909

https://github.com/facebook/react-native/releases/tag/v0.80.0

💚 How did you test it?

Manual, CI

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2025 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 423.09 ms 424.90 ms 1.81 ms
Size 17.75 MiB 20.15 MiB 2.40 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
52d9c3f 481.48 ms 468.53 ms -12.95 ms
6e8a851 425.59 ms 433.51 ms 7.92 ms
1f1c420 403.32 ms 411.98 ms 8.66 ms
bdb324a 422.22 ms 457.88 ms 35.65 ms
c352c30 331.98 ms 321.78 ms -10.20 ms
7d3c3cb 444.85 ms 456.65 ms 11.81 ms
0e42017 402.23 ms 415.04 ms 12.81 ms
69721ae 424.85 ms 415.28 ms -9.57 ms
b4d6bde 425.51 ms 417.37 ms -8.14 ms
f2c6fa5 445.15 ms 449.13 ms 3.98 ms

App size

Revision Plain With Sentry Diff
52d9c3f 17.75 MiB 20.15 MiB 2.40 MiB
6e8a851 17.75 MiB 20.15 MiB 2.40 MiB
1f1c420 17.75 MiB 20.15 MiB 2.40 MiB
bdb324a 17.75 MiB 20.15 MiB 2.40 MiB
c352c30 17.75 MiB 20.15 MiB 2.40 MiB
7d3c3cb 17.75 MiB 20.15 MiB 2.40 MiB
0e42017 17.75 MiB 20.15 MiB 2.40 MiB
69721ae 17.75 MiB 20.15 MiB 2.40 MiB
b4d6bde 17.75 MiB 20.15 MiB 2.40 MiB
f2c6fa5 17.75 MiB 20.15 MiB 2.40 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2025 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 366.57 ms 370.94 ms 4.37 ms
Size 7.15 MiB 8.42 MiB 1.26 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e12044e+dirty 404.20 ms 398.15 ms -6.06 ms
7d3c3cb+dirty 395.20 ms 413.24 ms 18.04 ms
38a1af2+dirty 421.38 ms 431.35 ms 9.97 ms
f2c6fa5+dirty 435.84 ms 433.84 ms -2.00 ms
69721ae+dirty 423.63 ms 417.34 ms -6.29 ms
1f1c420+dirty 383.31 ms 386.98 ms 3.67 ms
398e5d0+dirty 422.88 ms 444.98 ms 22.10 ms
0e42017+dirty 387.33 ms 399.30 ms 11.97 ms
bdb324a+dirty 401.10 ms 401.16 ms 0.06 ms
6e8a851+dirty 403.44 ms 430.87 ms 27.43 ms

App size

Revision Plain With Sentry Diff
e12044e+dirty 7.15 MiB 8.42 MiB 1.26 MiB
7d3c3cb+dirty 7.15 MiB 8.42 MiB 1.26 MiB
38a1af2+dirty 7.15 MiB 8.42 MiB 1.26 MiB
f2c6fa5+dirty 7.15 MiB 8.42 MiB 1.26 MiB
69721ae+dirty 7.15 MiB 8.42 MiB 1.26 MiB
1f1c420+dirty 7.15 MiB 8.42 MiB 1.26 MiB
398e5d0+dirty 7.15 MiB 8.42 MiB 1.26 MiB
0e42017+dirty 7.15 MiB 8.42 MiB 1.26 MiB
bdb324a+dirty 7.15 MiB 8.42 MiB 1.26 MiB
6e8a851+dirty 7.15 MiB 8.42 MiB 1.26 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2025 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1220.81 ms 1217.25 ms -3.56 ms
Size 2.63 MiB 3.79 MiB 1.15 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
38a1af2+dirty 1210.07 ms 1212.75 ms 2.68 ms
e12044e+dirty 1233.45 ms 1233.66 ms 0.21 ms
b4d6bde+dirty 1223.22 ms 1243.56 ms 20.34 ms
8bd8033+dirty 1213.33 ms 1220.88 ms 7.55 ms
6e8a851+dirty 1227.96 ms 1235.61 ms 7.65 ms
c352c30+dirty 1216.60 ms 1231.37 ms 14.77 ms
ec2a485+dirty 1219.72 ms 1224.66 ms 4.94 ms
7d3c3cb+dirty 1226.39 ms 1227.10 ms 0.71 ms
bdb324a+dirty 1229.33 ms 1236.61 ms 7.29 ms
df5da5d+dirty 1235.98 ms 1243.41 ms 7.43 ms

App size

Revision Plain With Sentry Diff
38a1af2+dirty 2.63 MiB 3.79 MiB 1.15 MiB
e12044e+dirty 2.63 MiB 3.78 MiB 1.15 MiB
b4d6bde+dirty 2.63 MiB 3.77 MiB 1.14 MiB
8bd8033+dirty 2.63 MiB 3.78 MiB 1.15 MiB
6e8a851+dirty 2.63 MiB 3.78 MiB 1.15 MiB
c352c30+dirty 2.63 MiB 3.78 MiB 1.15 MiB
ec2a485+dirty 2.63 MiB 3.78 MiB 1.15 MiB
7d3c3cb+dirty 2.63 MiB 3.78 MiB 1.15 MiB
bdb324a+dirty 2.63 MiB 3.79 MiB 1.15 MiB
df5da5d+dirty 2.63 MiB 3.78 MiB 1.15 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2025 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1230.06 ms 1229.90 ms -0.16 ms
Size 3.19 MiB 4.35 MiB 1.17 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
38a1af2+dirty 1211.57 ms 1219.27 ms 7.70 ms
0e42017+dirty 1235.77 ms 1247.43 ms 11.66 ms
7d3c3cb+dirty 1214.56 ms 1234.53 ms 19.97 ms
e12044e+dirty 1234.49 ms 1228.85 ms -5.64 ms
df5da5d+dirty 1226.82 ms 1234.88 ms 8.06 ms
6e8a851+dirty 1222.57 ms 1223.67 ms 1.10 ms
bdb324a+dirty 1230.02 ms 1226.18 ms -3.84 ms
c352c30+dirty 1229.65 ms 1241.33 ms 11.67 ms
940bd65+dirty 1224.39 ms 1215.57 ms -8.82 ms
69721ae+dirty 1251.53 ms 1253.69 ms 2.16 ms

App size

Revision Plain With Sentry Diff
38a1af2+dirty 3.19 MiB 4.35 MiB 1.17 MiB
0e42017+dirty 3.19 MiB 4.35 MiB 1.16 MiB
7d3c3cb+dirty 3.19 MiB 4.35 MiB 1.16 MiB
e12044e+dirty 3.19 MiB 4.35 MiB 1.17 MiB
df5da5d+dirty 3.19 MiB 4.35 MiB 1.17 MiB
6e8a851+dirty 3.19 MiB 4.35 MiB 1.17 MiB
bdb324a+dirty 3.19 MiB 4.35 MiB 1.17 MiB
c352c30+dirty 3.19 MiB 4.35 MiB 1.17 MiB
940bd65+dirty 3.19 MiB 4.35 MiB 1.16 MiB
69721ae+dirty 3.19 MiB 4.35 MiB 1.17 MiB

antonis
antonis commented Jun 19, 2025
View reviewed changes
Copy link
Contributor Author

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with a fresh RN 0.80.0 app from template and worked as expected.

  • npx @react-native-community/cli@latest init rn080test
  • npx @sentry/wizard@latest -i reactNative

Thus the issue should rely on the current E2E app setup.

@antonis antonis changed the title test(e2e): Bump RN version to 0.80.0 chore(deps): Support RN 0.80.0 Jun 23, 2025
@antonis antonis marked this pull request as ready for review June 23, 2025 16:59
@antonis antonis requested a review from lucas-zimerman as a code owner June 23, 2025 16:59
lucas-zimerman
lucas-zimerman approved these changes Jun 24, 2025
View reviewed changes
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a big feature!
I haven't seen any issues when checking the PR!
LGTM!

@antonis antonis merged commit 9e3030a into main Jun 24, 2025
110 of 112 checks passed
@antonis antonis deleted the antonis/e2e-rn0.80.0 branch June 24, 2025 13:42
nathan-ahn pushed a commit to nathan-ahn/sentry-react-native that referenced this pull request Sep 14, 2025
@antonis @nathan-ahn
chore(deps): Support RN 0.80.0 (getsentry#4938)
41762a9 
* test(e2e): Bump RN version to 0.80.0

* Remove folly_flags

* Run codegen on Android

* Fix Android codegen script

* Adds changelog

* Handle the new rndiff app structure

* Remove folly_flags conditionally
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucas-zimerman lucas-zimerman lucas-zimerman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support React Native 0.80

3 participants

@antonis @lucas-zimerman