-
-
Notifications
You must be signed in to change notification settings - Fork 354
fix(environment): remove deprecated appOwnership constant
#4893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(environment): remove deprecated appOwnership constant
#4893
Conversation
antonis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Thank you for following up and your contribution @pchalupa 🙇
|
Hi @pchalupa, @antonis My only concern is that Since we are currently working on a Sentry RN SDK v7, it's up to discussion, but I think this would be a good addition to it. |
Good point @krystofwoldrich 👍 Yes, let's iterate on this in the context of v7. |
krystofwoldrich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
📢 Type of change
📜 Description
This follow-up on #4892 removes deprecated appOwnership from the environment utils.
This PR proposes a detection of the Expo Go app based on the presence of the ExpoGo module. This assumption is based on the following comment and testing a sample app in Expo Go and dev client apps.
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps