fix(appStart): Add frame data in app start span #4865
+290
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonis
changed the title
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7d3c3cb | 444.85 ms | 456.65 ms | 11.81 ms |
| 0e42017 | 402.23 ms | 415.04 ms | 12.81 ms |
| b4d6bde | 425.51 ms | 417.37 ms | -8.14 ms |
| 940bd65 | 466.31 ms | 458.52 ms | -7.79 ms |
| df5da5d | 425.55 ms | 432.96 ms | 7.41 ms |
| ec2a485 | 450.84 ms | 447.49 ms | -3.35 ms |
| 1f1c420 | 403.32 ms | 411.98 ms | 8.66 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 7d3c3cb | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| 0e42017 | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| b4d6bde | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| 940bd65 | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| df5da5d | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| ec2a485 | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| 1f1c420 | 17.75 MiB | 20.15 MiB | 2.40 MiB |
Previous results on branch: antonis/appstart-frames
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 316bdde | 410.04 ms | 432.95 ms | 22.91 ms |
| 8a3bfd9 | 419.98 ms | 416.00 ms | -3.98 ms |
| b2affff | 475.47 ms | 473.64 ms | -1.83 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 316bdde | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| 8a3bfd9 | 17.75 MiB | 20.15 MiB | 2.40 MiB |
| b2affff | 17.75 MiB | 20.15 MiB | 2.40 MiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0e42017+dirty | 387.33 ms | 399.30 ms | 11.97 ms |
| 7d3c3cb+dirty | 395.20 ms | 413.24 ms | 18.04 ms |
| 940bd65+dirty | 408.45 ms | 419.75 ms | 11.30 ms |
| df5da5d+dirty | 415.54 ms | 456.96 ms | 41.42 ms |
| b4d6bde+dirty | 390.51 ms | 385.60 ms | -4.91 ms |
| 1f1c420+dirty | 383.31 ms | 386.98 ms | 3.67 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0e42017+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| 7d3c3cb+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| 940bd65+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| df5da5d+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| b4d6bde+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| 1f1c420+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
Previous results on branch: antonis/appstart-frames
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8a3bfd9+dirty | 415.89 ms | 430.87 ms | 14.98 ms |
| b2affff+dirty | 474.94 ms | 458.52 ms | -16.42 ms |
| 316bdde+dirty | 406.72 ms | 406.41 ms | -0.31 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8a3bfd9+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| b2affff+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
| 316bdde+dirty | 7.15 MiB | 8.42 MiB | 1.26 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b4d6bde+dirty | 1223.22 ms | 1243.56 ms | 20.34 ms |
| 7d3c3cb+dirty | 1226.39 ms | 1227.10 ms | 0.71 ms |
| 1f1c420+dirty | 1216.77 ms | 1214.48 ms | -2.29 ms |
| df5da5d+dirty | 1235.98 ms | 1243.41 ms | 7.43 ms |
| 940bd65+dirty | 1216.88 ms | 1225.23 ms | 8.35 ms |
| 0e42017+dirty | 1225.89 ms | 1231.63 ms | 5.74 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b4d6bde+dirty | 2.63 MiB | 3.77 MiB | 1.14 MiB |
| 7d3c3cb+dirty | 2.63 MiB | 3.78 MiB | 1.15 MiB |
| 1f1c420+dirty | 2.63 MiB | 3.77 MiB | 1.14 MiB |
| df5da5d+dirty | 2.63 MiB | 3.78 MiB | 1.15 MiB |
| 940bd65+dirty | 2.63 MiB | 3.78 MiB | 1.15 MiB |
| 0e42017+dirty | 2.63 MiB | 3.78 MiB | 1.15 MiB |
Previous results on branch: antonis/appstart-frames
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8a3bfd9+dirty | 1225.81 ms | 1229.79 ms | 3.98 ms |
| b2affff+dirty | 1222.06 ms | 1221.27 ms | -0.80 ms |
| 316bdde+dirty | 1223.49 ms | 1236.15 ms | 12.66 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8a3bfd9+dirty | 2.63 MiB | 3.78 MiB | 1.14 MiB |
| b2affff+dirty | 2.63 MiB | 3.78 MiB | 1.15 MiB |
| 316bdde+dirty | 2.63 MiB | 3.78 MiB | 1.15 MiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b4d6bde+dirty | 1218.73 ms | 1223.26 ms | 4.53 ms |
| 7d3c3cb+dirty | 1214.56 ms | 1234.53 ms | 19.97 ms |
| 1f1c420+dirty | 1238.06 ms | 1234.04 ms | -4.02 ms |
| df5da5d+dirty | 1226.82 ms | 1234.88 ms | 8.06 ms |
| 940bd65+dirty | 1224.39 ms | 1215.57 ms | -8.82 ms |
| 0e42017+dirty | 1235.77 ms | 1247.43 ms | 11.66 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b4d6bde+dirty | 3.19 MiB | 4.34 MiB | 1.16 MiB |
| 7d3c3cb+dirty | 3.19 MiB | 4.35 MiB | 1.16 MiB |
| 1f1c420+dirty | 3.19 MiB | 4.34 MiB | 1.16 MiB |
| df5da5d+dirty | 3.19 MiB | 4.35 MiB | 1.17 MiB |
| 940bd65+dirty | 3.19 MiB | 4.35 MiB | 1.16 MiB |
| 0e42017+dirty | 3.19 MiB | 4.35 MiB | 1.16 MiB |
Previous results on branch: antonis/appstart-frames
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8a3bfd9+dirty | 1220.87 ms | 1237.55 ms | 16.68 ms |
| b2affff+dirty | 1229.60 ms | 1227.96 ms | -1.64 ms |
| 316bdde+dirty | 1221.72 ms | 1218.04 ms | -3.68 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8a3bfd9+dirty | 3.19 MiB | 4.34 MiB | 1.16 MiB |
| b2affff+dirty | 3.19 MiB | 4.35 MiB | 1.17 MiB |
| 316bdde+dirty | 3.19 MiB | 4.35 MiB | 1.17 MiB |
|
I would add a sub issue to keep track of the missing native data. |
Good point @lucas-zimerman 👍 Created #4869 |
lucas-zimerman
approved these changes
May 28, 2025
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
This was referenced May 29, 2025
antonis
commented
Jun 9, 2025
CHANGELOG.md
Outdated
| @@ -52,6 +52,7 @@ | |||
| - Use engine-specific promise rejection tracking ([#4826](https://github.com/getsentry/sentry-react-native/pull/4826)) | |||
| - Fixes Feedback Widget accessibility issue on iOS ([#4739](https://github.com/getsentry/sentry-react-native/pull/4739)) | |||
| - Measuring TTID or TTFD could cause a crash when `parentSpanId` was removed ([#4881](https://github.com/getsentry/sentry-react-native/pull/4881)) | |||
| - Report slow and frozen frames as app start span data ([#4865](https://github.com/getsentry/sentry-react-native/pull/4865)) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Add frame data in app start span.
Note: The
frames.delay(as it appears in the #4723 example) is not added with this PR since it would require native changes. To keep the implementation simple a followup PR will tackle #4869💡 Motivation and Context
Partially #4723
💚 How did you test it?
CI, Manual
Examples: cold, warm
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps