Skip to content

chore(deps): update Cocoa SDK to v8.51.1 #4839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

chore(deps): update Cocoa SDK to v8.51.1 #4839

merged 1 commit into from
May 23, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 20, 2025 •
edited
Loading

Bumps scripts/update-cocoa.sh from 8.50.2 to 8.51.1.

Auto-generated by a dependency updater.

Changelog

8.51.1

Fixes

  • Uses low-priority queues to reduce the chance of session replay internal multi-threading processes being dropped (#5280)

Improvements

  • Threading issues in internal dependency container (#5225)

8.51.0

Important

This version creates new issue groups for your unhandled C++ exceptions because it now again reports the message of unhandled C++ exceptions, which we use for grouping.

Features

  • Apps can now manually show and hide the included feedback widget button (#5236)

Fixes

  • Reporting unhandled C++ exception message (#5190)
  • Improved internal multi-threading of session replay to fix thread inversion warning and reduce chance of queue starvation (#5018)

Improvements

  • Add itemCount to SentryEnvelopeItemHeader (#5230)
  • Improve warn log in SentryTracer (#5248)

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label May 20, 2025
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch from ae97703 to cb8e09c Compare May 20, 2025 03:20
@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented May 20, 2025 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 438.96 ms 446.72 ms 7.76 ms
Size 17.75 MiB 20.15 MiB 2.40 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e754436 472.72 ms 480.96 ms 8.23 ms
7f6950b 438.74 ms 430.71 ms -8.03 ms
148f924 492.65 ms 500.28 ms 7.63 ms
7301787 412.13 ms 405.46 ms -6.67 ms
60d7316 418.46 ms 414.12 ms -4.34 ms
1c9e040 325.02 ms 311.57 ms -13.45 ms
86818c7 444.76 ms 465.25 ms 20.49 ms
d8668ce 452.13 ms 435.06 ms -17.07 ms
87d396c 463.52 ms 500.31 ms 36.79 ms
73fc872 468.12 ms 483.07 ms 14.95 ms

App size

Revision Plain With Sentry Diff
e754436 17.75 MiB 20.13 MiB 2.38 MiB
7f6950b 17.74 MiB 20.10 MiB 2.36 MiB
148f924 17.73 MiB 19.94 MiB 2.21 MiB
7301787 17.75 MiB 20.13 MiB 2.38 MiB
60d7316 17.75 MiB 20.11 MiB 2.36 MiB
1c9e040 17.75 MiB 20.11 MiB 2.37 MiB
86818c7 17.75 MiB 20.12 MiB 2.37 MiB
d8668ce 17.74 MiB 20.08 MiB 2.34 MiB
87d396c 17.75 MiB 20.13 MiB 2.38 MiB
73fc872 17.75 MiB 20.13 MiB 2.38 MiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
7140a40 664.39 ms 656.44 ms -7.95 ms
1dfac94 420.94 ms 408.17 ms -12.77 ms
12e4be5 433.46 ms 417.33 ms -16.13 ms
6492e76 424.30 ms 414.10 ms -10.20 ms
438739d 442.02 ms 457.96 ms 15.94 ms
3620199 402.58 ms 399.48 ms -3.10 ms
ef18299 429.64 ms 466.56 ms 36.92 ms
a9355d1 488.72 ms 557.00 ms 68.28 ms
4a86286 414.04 ms 415.15 ms 1.11 ms
6858e4c 421.02 ms 417.54 ms -3.48 ms

App size

Revision Plain With Sentry Diff
7140a40 17.74 MiB 20.08 MiB 2.35 MiB
1dfac94 17.75 MiB 20.13 MiB 2.38 MiB
12e4be5 17.75 MiB 20.12 MiB 2.37 MiB
6492e76 17.75 MiB 20.13 MiB 2.38 MiB
438739d 17.75 MiB 20.11 MiB 2.37 MiB
3620199 17.75 MiB 20.13 MiB 2.38 MiB
ef18299 17.75 MiB 20.13 MiB 2.38 MiB
a9355d1 17.74 MiB 20.10 MiB 2.36 MiB
4a86286 17.75 MiB 20.13 MiB 2.38 MiB
6858e4c 17.75 MiB 20.12 MiB 2.37 MiB

@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented May 20, 2025 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 420.44 ms 444.68 ms 24.24 ms
Size 7.15 MiB 8.42 MiB 1.26 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
76d1baf+dirty 339.02 ms 408.65 ms 69.63 ms
bd0ca38+dirty 272.43 ms 290.67 ms 18.24 ms
c830127+dirty 352.35 ms 388.96 ms 36.61 ms
86818c7+dirty 362.79 ms 376.04 ms 13.25 ms
d7401ac+dirty 373.98 ms 394.08 ms 20.10 ms
43e66e0+dirty 378.20 ms 404.59 ms 26.40 ms
e754436+dirty 424.60 ms 478.19 ms 53.59 ms
d8668ce+dirty 372.43 ms 403.84 ms 31.41 ms
834729f+dirty 413.31 ms 400.80 ms -12.52 ms
5446992+dirty 371.61 ms 390.00 ms 18.39 ms

App size

Revision Plain With Sentry Diff
76d1baf+dirty 7.15 MiB 8.09 MiB 964.41 KiB
bd0ca38+dirty 7.15 MiB 8.40 MiB 1.25 MiB
c830127+dirty 7.15 MiB 8.38 MiB 1.23 MiB
86818c7+dirty 7.15 MiB 8.39 MiB 1.23 MiB
d7401ac+dirty 7.15 MiB 8.04 MiB 910.85 KiB
43e66e0+dirty 7.15 MiB 8.37 MiB 1.22 MiB
e754436+dirty 7.15 MiB 8.40 MiB 1.25 MiB
d8668ce+dirty 7.15 MiB 8.35 MiB 1.20 MiB
834729f+dirty 7.15 MiB 8.40 MiB 1.25 MiB
5446992+dirty 7.15 MiB 8.12 MiB 999.45 KiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
6858e4c+dirty 387.81 ms 376.10 ms -11.71 ms
a9355d1+dirty 374.27 ms 435.52 ms 61.25 ms
7140a40+dirty 419.33 ms 463.16 ms 43.83 ms
9c4a204+dirty 440.30 ms 484.81 ms 44.52 ms
e4aeaad+dirty 379.82 ms 379.89 ms 0.08 ms
6492e76+dirty 378.44 ms 380.92 ms 2.48 ms
62e1450+dirty 363.60 ms 401.13 ms 37.53 ms
438739d+dirty 394.50 ms 432.00 ms 37.50 ms
77364bc+dirty 368.47 ms 411.62 ms 43.16 ms
12e4be5+dirty 434.66 ms 447.90 ms 13.24 ms

App size

Revision Plain With Sentry Diff
6858e4c+dirty 7.15 MiB 8.39 MiB 1.23 MiB
a9355d1+dirty 7.15 MiB 8.38 MiB 1.23 MiB
7140a40+dirty 7.15 MiB 8.36 MiB 1.21 MiB
9c4a204+dirty 7.15 MiB 8.35 MiB 1.20 MiB
e4aeaad+dirty 7.15 MiB 8.39 MiB 1.23 MiB
6492e76+dirty 7.15 MiB 8.40 MiB 1.25 MiB
62e1450+dirty 7.15 MiB 8.36 MiB 1.21 MiB
438739d+dirty 7.15 MiB 8.38 MiB 1.23 MiB
77364bc+dirty 7.15 MiB 8.36 MiB 1.21 MiB
12e4be5+dirty 7.15 MiB 8.39 MiB 1.23 MiB

@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented May 20, 2025 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1210.94 ms 1211.40 ms 0.46 ms
Size 3.19 MiB 4.34 MiB 1.16 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8f0282e+dirty 1225.33 ms 1229.92 ms 4.59 ms
f8fa2ad+dirty 1227.51 ms 1212.89 ms -14.62 ms
686b3bc+dirty 1219.65 ms 1231.73 ms 12.08 ms
d7401ac+dirty 1288.10 ms 1289.54 ms 1.44 ms
9de3d45+dirty 1228.37 ms 1231.79 ms 3.42 ms
148f924+dirty 1220.72 ms 1221.30 ms 0.58 ms
800171e+dirty 1222.94 ms 1235.82 ms 12.88 ms
a0b0298+dirty 1227.71 ms 1234.12 ms 6.41 ms
ce76a0b+dirty 1220.49 ms 1229.29 ms 8.80 ms
0d3e677+dirty 1239.02 ms 1241.22 ms 2.20 ms

App size

Revision Plain With Sentry Diff
8f0282e+dirty 3.19 MiB 4.33 MiB 1.14 MiB
f8fa2ad+dirty 3.19 MiB 4.35 MiB 1.16 MiB
686b3bc+dirty 3.19 MiB 4.31 MiB 1.12 MiB
d7401ac+dirty 2.92 MiB 3.40 MiB 488.06 KiB
9de3d45+dirty 3.19 MiB 4.33 MiB 1.14 MiB
148f924+dirty 2.92 MiB 3.60 MiB 701.88 KiB
800171e+dirty 3.19 MiB 4.25 MiB 1.06 MiB
a0b0298+dirty 3.19 MiB 4.32 MiB 1.13 MiB
ce76a0b+dirty 3.19 MiB 4.35 MiB 1.16 MiB
0d3e677+dirty 2.92 MiB 3.66 MiB 758.42 KiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
62e1450+dirty 1231.73 ms 1234.63 ms 2.90 ms
60da2b3+dirty 1230.44 ms 1232.47 ms 2.03 ms
6492e76+dirty 1226.37 ms 1226.78 ms 0.41 ms
9c4a204+dirty 1250.62 ms 1244.24 ms -6.38 ms
438739d+dirty 1228.18 ms 1226.46 ms -1.73 ms
1dfac94+dirty 1230.76 ms 1231.53 ms 0.78 ms
09a2115+dirty 1232.63 ms 1244.80 ms 12.17 ms
3620199+dirty 1247.39 ms 1245.02 ms -2.37 ms
a9355d1+dirty 1231.51 ms 1239.04 ms 7.53 ms
e4aeaad+dirty 1212.94 ms 1216.24 ms 3.30 ms

App size

Revision Plain With Sentry Diff
62e1450+dirty 2.92 MiB 3.66 MiB 760.67 KiB
60da2b3+dirty 3.19 MiB 4.31 MiB 1.12 MiB
6492e76+dirty 3.19 MiB 4.34 MiB 1.16 MiB
9c4a204+dirty 2.92 MiB 3.64 MiB 741.21 KiB
438739d+dirty 3.19 MiB 4.27 MiB 1.08 MiB
1dfac94+dirty 3.19 MiB 4.35 MiB 1.16 MiB
09a2115+dirty 3.19 MiB 4.32 MiB 1.13 MiB
3620199+dirty 3.19 MiB 4.35 MiB 1.16 MiB
a9355d1+dirty 2.92 MiB 3.69 MiB 790.55 KiB
e4aeaad+dirty 3.19 MiB 4.33 MiB 1.14 MiB

@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented May 20, 2025 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1242.29 ms 1246.39 ms 4.10 ms
Size 2.63 MiB 3.77 MiB 1.14 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8f0282e+dirty 1215.46 ms 1219.64 ms 4.18 ms
f8fa2ad+dirty 1239.08 ms 1235.49 ms -3.59 ms
686b3bc+dirty 1210.89 ms 1221.14 ms 10.25 ms
d7401ac+dirty 1252.38 ms 1275.04 ms 22.66 ms
9de3d45+dirty 1229.16 ms 1229.58 ms 0.42 ms
148f924+dirty 1214.76 ms 1215.73 ms 0.97 ms
800171e+dirty 1229.96 ms 1232.87 ms 2.91 ms
a0b0298+dirty 1220.73 ms 1226.87 ms 6.14 ms
ce76a0b+dirty 1212.27 ms 1217.83 ms 5.56 ms
0d3e677+dirty 1214.39 ms 1225.70 ms 11.31 ms

App size

Revision Plain With Sentry Diff
8f0282e+dirty 2.63 MiB 3.76 MiB 1.13 MiB
f8fa2ad+dirty 2.63 MiB 3.78 MiB 1.14 MiB
686b3bc+dirty 2.63 MiB 3.74 MiB 1.11 MiB
d7401ac+dirty 2.36 MiB 2.83 MiB 481.14 KiB
9de3d45+dirty 2.63 MiB 3.77 MiB 1.13 MiB
148f924+dirty 2.36 MiB 3.04 MiB 696.25 KiB
800171e+dirty 2.63 MiB 3.69 MiB 1.05 MiB
a0b0298+dirty 2.63 MiB 3.75 MiB 1.12 MiB
ce76a0b+dirty 2.63 MiB 3.78 MiB 1.14 MiB
0d3e677+dirty 2.36 MiB 3.10 MiB 753.12 KiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
62e1450+dirty 1219.45 ms 1236.33 ms 16.88 ms
60da2b3+dirty 1212.45 ms 1222.61 ms 10.16 ms
6492e76+dirty 1218.27 ms 1221.04 ms 2.78 ms
9c4a204+dirty 1231.46 ms 1239.71 ms 8.25 ms
438739d+dirty 1213.33 ms 1216.20 ms 2.88 ms
1dfac94+dirty 1224.62 ms 1217.02 ms -7.60 ms
09a2115+dirty 1233.45 ms 1229.50 ms -3.95 ms
3620199+dirty 1214.30 ms 1212.92 ms -1.38 ms
a9355d1+dirty 1236.78 ms 1245.20 ms 8.43 ms
e4aeaad+dirty 1241.18 ms 1235.51 ms -5.67 ms

App size

Revision Plain With Sentry Diff
62e1450+dirty 2.36 MiB 3.10 MiB 755.61 KiB
60da2b3+dirty 2.63 MiB 3.74 MiB 1.11 MiB
6492e76+dirty 2.63 MiB 3.78 MiB 1.14 MiB
9c4a204+dirty 2.36 MiB 3.08 MiB 735.56 KiB
438739d+dirty 2.63 MiB 3.70 MiB 1.07 MiB
1dfac94+dirty 2.63 MiB 3.78 MiB 1.14 MiB
09a2115+dirty 2.63 MiB 3.75 MiB 1.12 MiB
3620199+dirty 2.63 MiB 3.78 MiB 1.15 MiB
a9355d1+dirty 2.36 MiB 3.12 MiB 779.40 KiB
e4aeaad+dirty 2.63 MiB 3.76 MiB 1.13 MiB

antonis
antonis reviewed May 20, 2025
View reviewed changes
Copy link
Collaborator

@antonis antonis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improved internal multi-threading of session replay to fix thread inversion warning and reduce chance of queue starvation (#5018)

The captureReplay E2E tests consistently fail on iOS and this might be related with the above PR. Further investigation is needed and possible changes before merging this version.

Looking at the CI logs the following error occurs.

Error: Could not fetch https://sentry.io/api/0/projects/sentry-sdks/sentry-react-native/replays/f2bc6751afd64f66b8a72df300464eb9/ within retry limit: 404 |

This might be related to the session replays not being ready since their processing priority is lower now 🤔

@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch from cb8e09c to 00b59eb Compare May 20, 2025 10:47
@antonis antonis mentioned this pull request May 20, 2025
Closed
10 tasks
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch 2 times, most recently from 6e8c463 to 2bdd07d Compare May 20, 2025 14:11
@antonis antonis mentioned this pull request May 20, 2025
Merged
10 tasks
@krystofwoldrich
Copy link
Member

Locally the test passes.

Screenshot 2025-05-20 at 17 36 55

@krystofwoldrich
Copy link
Member

Example of an exception which should include replay: https://sentry-sdks.sentry.io/issues/6457984349/?project=5428561&query=id%3Aa30a12d125ca4c0682dadbe38a8ff924&referrer=issue-stream&stream_index=0

Truly the replay was not uploaded.

@krystofwoldrich
Copy link
Member

@philprime Any ideas why after https://github-redirect.dependabot.com/getsentry/sentry-cocoa/issues/5018 replays would not work in CI?

@krystofwoldrich
Copy link
Member

Device logs are not supported but it's something we plan to add

(from https://docs.maestro.dev/troubleshooting/debug-output)

This might be quite difficult to debug since the debug logs don't contain the device/app logs.

@antonis
Copy link
Collaborator

antonis commented May 21, 2025

Thank you for looking at this @krystofwoldrich 🙇

Any ideas why after https://github-redirect.dependabot.com/getsentry/sentry-cocoa/issues/5018 replays would not work in CI?

Is there a chance that the QOS_CLASS_BACKGROUND priority never gets executed on the CI environment that has limited resources? Maybe we can try with a higher priority (e.g. QOS_CLASS_UTILITY or QOS_CLASS_DEFAULT for testing) to see if that helps.

@antonis
Copy link
Collaborator

antonis commented May 21, 2025 •
edited
Loading

Is there a chance that the QOS_CLASS_BACKGROUND priority never gets executed on the CI environment that has limited resources? Maybe we can try with a higher priority (e.g. QOS_CLASS_UTILITY or QOS_CLASS_DEFAULT for testing) to see if that helps.

I've tested this assumption with a draft PR using a Cocoa implementation with QOS_CLASS_DEFAULT priority. The tests passed for this meaning that the lower priority may have an impact when the resources are limited on CI.

@antonis antonis mentioned this pull request May 21, 2025
Closed
10 tasks
@antonis
Copy link
Collaborator

antonis commented May 21, 2025 •
edited
Loading

Is there a chance that the QOS_CLASS_BACKGROUND priority never gets executed on the CI environment that has limited resources? Maybe we can try with a higher priority (e.g. QOS_CLASS_UTILITY or QOS_CLASS_DEFAULT for testing) to see if that helps.

Also tested using a Cocoa implementation with QOS_CLASS_UTILITY priority. The tests also passed.
This means that only QOS_CLASS_BACKGROUND fails on CI.

@antonis
Copy link
Collaborator

antonis commented May 21, 2025

Tested QOS_CLASS_BACKGROUND priority with extra logging (and debug log level) with a draft RN PR. As expected the captureReplay E2E tests failed on iOS. Attaching the logs below.

Test RN 0.65.3 legacy jsc ios production no

maestro.log
sentry.log

Test RN 0.79.1 legacy hermes ios production no

maestro.log
sentry.log

Test RN 0.79.1 new hermes ios production no

maestro.log
sentry.log

@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch 2 times, most recently from 98197e3 to 4043e43 Compare May 22, 2025 08:15
@antonis
Copy link
Collaborator

antonis commented May 22, 2025

Attaching some more verbose logging with replaysSessionSampleRate/replaysOnErrorSampleRate to 1.0
replay.txt

@antonis antonis mentioned this pull request May 22, 2025
Merged
7 tasks
antonis
antonis reviewed May 22, 2025
View reviewed changes
Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also tested using a Cocoa implementation with QOS_CLASS_UTILITY priority. The tests also passed.
This means that only QOS_CLASS_BACKGROUND fails on CI.

A PR was opened to bump the priority to low getsentry/sentry-cocoa#5280

@github-actions github-actions bot changed the title chore(deps): update Cocoa SDK to v8.51.0 chore(deps): update Cocoa SDK to v8.51.1 May 23, 2025
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch from 4043e43 to 611fa3c Compare May 23, 2025 14:12
@antonis antonis self-requested a review May 23, 2025 15:53
antonis
antonis approved these changes May 23, 2025
View reviewed changes
Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and the CI tests pass!

@antonis antonis merged commit c4b4e7a into main May 23, 2025
174 of 180 checks passed
@antonis antonis deleted the deps/scripts/update-cocoa.sh branch May 23, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonis antonis antonis approved these changes

@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich krystofwoldrich is a code owner

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krystofwoldrich @antonis @web-flow