Skip to content

ci(e2e): Use exact Xcode version (16.2) for e2e tests #4624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 5, 2025

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Mar 5, 2025

Ensures that the clean app e2e tests run with exact xcode versions.

Old RN with Xcode 14.2
Latest RN with Xcode 16.2

#skip-changelog

Copy link
Contributor

github-actions bot commented Mar 5, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 438.52 ms 475.93 ms 37.41 ms
Size 17.75 MiB 20.12 MiB 2.37 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
700cbf4 425.56 ms 436.26 ms 10.70 ms
3f05680 397.91 ms 405.65 ms 7.74 ms
7e87527 425.56 ms 407.64 ms -17.93 ms
9672577 416.34 ms 421.26 ms 4.92 ms
2dc8f22 435.67 ms 417.00 ms -18.67 ms
fc150fe 414.15 ms 458.06 ms 43.91 ms
1d86dd6 405.14 ms 411.06 ms 5.92 ms
c991c90 418.78 ms 404.16 ms -14.62 ms
afe5fcb 322.46 ms 353.04 ms 30.58 ms
70e6261 482.65 ms 495.70 ms 13.05 ms

App size

Revision Plain With Sentry Diff
700cbf4 17.73 MiB 20.07 MiB 2.33 MiB
3f05680 17.75 MiB 20.11 MiB 2.37 MiB
7e87527 17.75 MiB 20.11 MiB 2.37 MiB
9672577 17.75 MiB 20.11 MiB 2.36 MiB
2dc8f22 17.75 MiB 20.11 MiB 2.37 MiB
fc150fe 17.75 MiB 20.11 MiB 2.37 MiB
1d86dd6 17.73 MiB 19.86 MiB 2.12 MiB
c991c90 17.75 MiB 20.11 MiB 2.36 MiB
afe5fcb 17.75 MiB 20.11 MiB 2.36 MiB
70e6261 17.73 MiB 19.94 MiB 2.21 MiB

Copy link
Contributor

github-actions bot commented Mar 5, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1211.84 ms 1239.46 ms 27.62 ms
Size 2.63 MiB 3.75 MiB 1.12 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8d251c2+dirty 1220.17 ms 1225.21 ms 5.05 ms
31fcca2+dirty 1209.17 ms 1216.21 ms 7.04 ms
13f280b+dirty 1229.25 ms 1226.10 ms -3.15 ms
153419c+dirty 1221.06 ms 1227.80 ms 6.73 ms
3ffcddd+dirty 1244.47 ms 1264.14 ms 19.67 ms
0db0c72+dirty 1275.02 ms 1285.84 ms 10.82 ms
d16beca+dirty 1215.94 ms 1228.20 ms 12.27 ms
1d7ae00+dirty 1240.55 ms 1248.60 ms 8.05 ms
5f03ae9+dirty 1232.29 ms 1230.92 ms -1.37 ms
5571a20+dirty 1203.57 ms 1204.57 ms 1.00 ms

App size

Revision Plain With Sentry Diff
8d251c2+dirty 2.63 MiB 3.69 MiB 1.05 MiB
31fcca2+dirty 2.36 MiB 2.90 MiB 552.95 KiB
13f280b+dirty 2.36 MiB 3.10 MiB 753.43 KiB
153419c+dirty 2.63 MiB 3.70 MiB 1.06 MiB
3ffcddd+dirty 2.36 MiB 2.84 MiB 489.60 KiB
0db0c72+dirty 2.36 MiB 2.84 MiB 487.01 KiB
d16beca+dirty 2.36 MiB 3.12 MiB 779.39 KiB
1d7ae00+dirty 2.63 MiB 3.75 MiB 1.12 MiB
5f03ae9+dirty 2.63 MiB 3.68 MiB 1.05 MiB
5571a20+dirty 2.36 MiB 2.92 MiB 569.93 KiB

Copy link
Contributor

github-actions bot commented Mar 5, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1228.84 ms 1238.65 ms 9.82 ms
Size 3.19 MiB 4.32 MiB 1.13 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8d251c2+dirty 1221.19 ms 1227.12 ms 5.93 ms
31fcca2+dirty 1222.04 ms 1226.51 ms 4.47 ms
13f280b+dirty 1217.73 ms 1229.08 ms 11.35 ms
153419c+dirty 1225.12 ms 1221.31 ms -3.82 ms
3ffcddd+dirty 1272.22 ms 1273.98 ms 1.76 ms
0db0c72+dirty 1258.88 ms 1262.52 ms 3.64 ms
d16beca+dirty 1239.00 ms 1233.89 ms -5.11 ms
1d7ae00+dirty 1240.33 ms 1239.51 ms -0.82 ms
5f03ae9+dirty 1237.79 ms 1241.02 ms 3.23 ms
5571a20+dirty 1228.09 ms 1233.45 ms 5.36 ms

App size

Revision Plain With Sentry Diff
8d251c2+dirty 3.19 MiB 4.25 MiB 1.06 MiB
31fcca2+dirty 2.92 MiB 3.46 MiB 557.31 KiB
13f280b+dirty 2.92 MiB 3.66 MiB 758.67 KiB
153419c+dirty 3.19 MiB 4.26 MiB 1.08 MiB
3ffcddd+dirty 2.92 MiB 3.40 MiB 494.39 KiB
0db0c72+dirty 2.92 MiB 3.40 MiB 492.71 KiB
d16beca+dirty 2.92 MiB 3.69 MiB 790.48 KiB
1d7ae00+dirty 3.19 MiB 4.32 MiB 1.13 MiB
5f03ae9+dirty 3.19 MiB 4.25 MiB 1.06 MiB
5571a20+dirty 2.92 MiB 3.48 MiB 575.54 KiB

@krystofwoldrich krystofwoldrich marked this pull request as ready for review March 5, 2025 12:05
Copy link
Contributor

github-actions bot commented Mar 5, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 623.63 ms 643.33 ms 19.69 ms
Size 7.15 MiB 8.39 MiB 1.23 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
690220d+dirty 492.10 ms 473.88 ms -18.23 ms
d8668ce+dirty 372.43 ms 403.84 ms 31.41 ms
1e28462+dirty 490.52 ms 536.94 ms 46.42 ms
e2b64fe+dirty 258.82 ms 304.26 ms 45.44 ms
31fcca2+dirty 366.64 ms 395.78 ms 29.14 ms
c6f01ea+dirty 379.95 ms 439.35 ms 59.40 ms
8900e1a+dirty 371.40 ms 377.70 ms 6.31 ms
15c80ab+dirty 276.38 ms 327.54 ms 51.17 ms
9cab16b+dirty 370.82 ms 416.37 ms 45.55 ms
0ebca77+dirty 360.94 ms 402.24 ms 41.30 ms

App size

Revision Plain With Sentry Diff
690220d+dirty 7.15 MiB 8.36 MiB 1.21 MiB
d8668ce+dirty 7.15 MiB 8.35 MiB 1.20 MiB
1e28462+dirty 7.15 MiB 8.38 MiB 1.23 MiB
e2b64fe+dirty 7.15 MiB 8.07 MiB 947.16 KiB
31fcca2+dirty 7.15 MiB 8.18 MiB 1.03 MiB
c6f01ea+dirty 7.15 MiB 8.37 MiB 1.22 MiB
8900e1a+dirty 7.15 MiB 8.03 MiB 901.79 KiB
15c80ab+dirty 7.15 MiB 8.09 MiB 966.13 KiB
9cab16b+dirty 7.15 MiB 8.35 MiB 1.20 MiB
0ebca77+dirty 7.15 MiB 8.22 MiB 1.07 MiB

Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@krystofwoldrich krystofwoldrich merged commit b7eb05d into main Mar 5, 2025
71 of 72 checks passed
@krystofwoldrich krystofwoldrich deleted the kw-use-16-2-in-e2e-tests branch March 5, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants