Ref: Handle nested json configuration structures by antonis · Pull Request #4470 · getsentry/sentry-react-native

antonis · 2025-01-21T10:40:51Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

Depends on #4469

📜 Description

⛓️ PR Chain

💡 Motivation and Context

See #4451 (comment)
Part of #3608

💚 How did you test it?

CI, Manual

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

#skip-changelog

github-actions · 2025-01-21T10:52:12Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	437.49 ms	438.28 ms	0.79 ms
Size	17.75 MiB	20.11 MiB	2.37 MiB

Baseline results on branch: antonis/ref-convertToWritable

Startup times

Revision	Plain	With Sentry	Diff
`865c0d9`	459.00 ms	456.18 ms	-2.82 ms
`4ac2cff`	445.40 ms	431.02 ms	-14.38 ms
`6a80f44`	465.20 ms	460.86 ms	-4.35 ms

App size

Revision	Plain	With Sentry	Diff
`865c0d9`	17.75 MiB	20.11 MiB	2.37 MiB
`4ac2cff`	17.75 MiB	20.11 MiB	2.37 MiB
`6a80f44`	17.75 MiB	20.11 MiB	2.37 MiB

Previous results on branch: antonis/ref-RNSentryJsonUtils

Startup times

Revision	Plain	With Sentry	Diff
`11c0bc5`	419.08 ms	454.54 ms	35.46 ms
`eff021d`	428.13 ms	417.82 ms	-10.31 ms
`f9a2e3c`	449.64 ms	469.63 ms	19.99 ms

App size

Revision	Plain	With Sentry	Diff
`11c0bc5`	17.75 MiB	20.11 MiB	2.37 MiB
`eff021d`	17.75 MiB	20.11 MiB	2.37 MiB
`f9a2e3c`	17.75 MiB	20.11 MiB	2.37 MiB

github-actions · 2025-01-21T11:01:21Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	419.58 ms	492.81 ms	73.23 ms
Size	7.15 MiB	8.38 MiB	1.23 MiB

Baseline results on branch: antonis/ref-convertToWritable

Startup times

Revision	Plain	With Sentry	Diff
`4ac2cff`+dirty	390.09 ms	401.72 ms	11.64 ms
`865c0d9`+dirty	342.12 ms	366.85 ms	24.73 ms
`6a80f44`+dirty	416.28 ms	487.90 ms	71.62 ms

App size

Revision	Plain	With Sentry	Diff
`4ac2cff`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`865c0d9`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`6a80f44`+dirty	7.15 MiB	8.38 MiB	1.23 MiB

Previous results on branch: antonis/ref-RNSentryJsonUtils

Startup times

Revision	Plain	With Sentry	Diff
`f9a2e3c`+dirty	386.92 ms	435.47 ms	48.55 ms
`11c0bc5`+dirty	393.98 ms	421.85 ms	27.87 ms
`eff021d`+dirty	404.96 ms	469.09 ms	64.13 ms

App size

Revision	Plain	With Sentry	Diff
`f9a2e3c`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`11c0bc5`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`eff021d`+dirty	7.15 MiB	8.38 MiB	1.23 MiB

…yJsonUtils

github-actions · 2025-01-21T11:38:22Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1230.14 ms	1228.02 ms	-2.12 ms
Size	2.63 MiB	3.69 MiB	1.05 MiB

Baseline results on branch: antonis/ref-convertToWritable

Startup times

Revision	Plain	With Sentry	Diff
`6a80f44`+dirty	1227.69 ms	1227.96 ms	0.26 ms
`865c0d9`+dirty	1218.47 ms	1220.91 ms	2.45 ms
`4ac2cff`+dirty	1209.27 ms	1211.71 ms	2.44 ms

App size

Revision	Plain	With Sentry	Diff
`6a80f44`+dirty	2.63 MiB	3.69 MiB	1.05 MiB
`865c0d9`+dirty	2.63 MiB	3.69 MiB	1.05 MiB
`4ac2cff`+dirty	2.63 MiB	3.69 MiB	1.05 MiB

Previous results on branch: antonis/ref-RNSentryJsonUtils

Startup times

Revision	Plain	With Sentry	Diff
`11c0bc5`+dirty	1215.18 ms	1217.63 ms	2.45 ms
`eff021d`+dirty	1233.80 ms	1221.47 ms	-12.33 ms
`f9a2e3c`+dirty	1230.61 ms	1221.64 ms	-8.97 ms

App size

Revision	Plain	With Sentry	Diff
`11c0bc5`+dirty	2.63 MiB	3.69 MiB	1.05 MiB
`eff021d`+dirty	2.63 MiB	3.69 MiB	1.05 MiB
`f9a2e3c`+dirty	2.63 MiB	3.69 MiB	1.05 MiB

github-actions · 2025-01-21T11:46:24Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1220.79 ms	1221.85 ms	1.06 ms
Size	3.19 MiB	4.25 MiB	1.06 MiB

Baseline results on branch: antonis/ref-convertToWritable

Startup times

Revision	Plain	With Sentry	Diff
`6a80f44`+dirty	1229.63 ms	1221.77 ms	-7.86 ms
`865c0d9`+dirty	1229.65 ms	1229.57 ms	-0.08 ms
`4ac2cff`+dirty	1217.83 ms	1228.10 ms	10.27 ms

App size

Revision	Plain	With Sentry	Diff
`6a80f44`+dirty	3.19 MiB	4.25 MiB	1.06 MiB
`865c0d9`+dirty	3.19 MiB	4.25 MiB	1.06 MiB
`4ac2cff`+dirty	3.19 MiB	4.25 MiB	1.06 MiB

Previous results on branch: antonis/ref-RNSentryJsonUtils

Startup times

Revision	Plain	With Sentry	Diff
`11c0bc5`+dirty	1242.98 ms	1250.56 ms	7.58 ms
`eff021d`+dirty	1228.45 ms	1220.27 ms	-8.18 ms
`f9a2e3c`+dirty	1222.06 ms	1223.62 ms	1.56 ms

App size

Revision	Plain	With Sentry	Diff
`11c0bc5`+dirty	3.19 MiB	4.25 MiB	1.06 MiB
`eff021d`+dirty	3.19 MiB	4.25 MiB	1.06 MiB
`f9a2e3c`+dirty	3.19 MiB	4.25 MiB	1.06 MiB

…yJsonUtils

krystofwoldrich · 2025-01-22T15:02:37Z

...roidTester/app/src/androidTest/java/io/sentry/rnsentryandroidtester/RNSentryJsonUtilsTest.kt

+    @Before
+    fun setUp() {
+        val context: Context = InstrumentationRegistry.getInstrumentation().targetContext
+        SoLoader.init(context, false)
+    }


This should not be needed. Let's remove it, to know 100% that these conversions can run before the RN initializes.

krystofwoldrich · 2025-01-22T15:13:58Z

...roidTester/app/src/androidTest/java/io/sentry/rnsentryandroidtester/RNSentryJsonUtilsTest.kt

+            JSONObject().apply {
+                put("stringKey", "stringValue")
+                put("booleanKey", true)
+                put("intKey", 123)


Let's also test test doubles/floats as those are common in Sentry configs.

krystofwoldrich · 2025-01-22T15:20:59Z

packages/core/android/src/main/java/io/sentry/react/RNSentryJsonUtils.java

+import org.json.JSONException;
+import org.json.JSONObject;
+
+public final class RNSentryJsonUtils {


Let's not expose this outside of the package.

antonis · 2025-01-23T14:27:23Z

Closing in favour of a simpler implementation in #4479

antonis added 2 commits January 21, 2025 12:06

Extract Json related functions to a separate utility class

ab032e9

Handle nested Json structures

bb42031

Merge branch 'antonis/ref-convertToWritable' into antonis/ref-RNSentr…

0783686

…yJsonUtils

Adds test for deep nested json structures

31c6299

antonis marked this pull request as ready for review January 21, 2025 12:24

antonis requested review from krystofwoldrich and lucas-zimerman as code owners January 21, 2025 12:24

antonis added 3 commits January 21, 2025 17:36

Merge branch 'antonis/ref-convertToWritable' into antonis/ref-RNSentr…

ad460d5

…yJsonUtils

Adds Javadoc and null annotations in json utils

5fb03ef

Merge branch 'antonis/ref-convertToWritable' into antonis/ref-RNSentr…

1b0b11d

…yJsonUtils

antonis mentioned this pull request Jan 21, 2025

Fail gracefully when the provided json is not valid #4474

Closed

10 tasks

antonis added 2 commits January 22, 2025 09:51

Merge branch 'antonis/ref-convertToWritable' into antonis/ref-RNSentr…

63e8cbf

…yJsonUtils

Merge branch 'antonis/ref-convertToWritable' into antonis/ref-RNSentr…

f820b64

…yJsonUtils

krystofwoldrich reviewed Jan 22, 2025

View reviewed changes

krystofwoldrich mentioned this pull request Jan 23, 2025

Adds utility class for converting JsonObject to WritableMap #4479

Merged

10 tasks

antonis closed this Jan 23, 2025

Uh oh!

Conversation

antonis commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

⛓️ PR Chain

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: antonis/ref-convertToWritable

Startup times

App size

Previous results on branch: antonis/ref-RNSentryJsonUtils

Startup times

App size

Uh oh!

github-actions bot commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (new) Performance metrics 🚀

Baseline results on branch: antonis/ref-convertToWritable

Startup times

App size

Previous results on branch: antonis/ref-RNSentryJsonUtils

Startup times

App size

Uh oh!

github-actions bot commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: antonis/ref-convertToWritable

Startup times

App size

Previous results on branch: antonis/ref-RNSentryJsonUtils

Startup times

App size

Uh oh!

github-actions bot commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (new) Performance metrics 🚀

Baseline results on branch: antonis/ref-convertToWritable

Startup times

App size

Previous results on branch: antonis/ref-RNSentryJsonUtils

Startup times

App size

Uh oh!

krystofwoldrich Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

krystofwoldrich Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

krystofwoldrich Jan 22, 2025

Choose a reason for hiding this comment

Uh oh!

antonis commented Jan 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

antonis commented Jan 21, 2025 •

edited

Loading

github-actions bot commented Jan 21, 2025 •

edited

Loading

github-actions bot commented Jan 21, 2025 •

edited

Loading

github-actions bot commented Jan 21, 2025 •

edited

Loading

github-actions bot commented Jan 21, 2025 •

edited

Loading

krystofwoldrich Jan 22, 2025 •

edited

Loading