Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore JavascriptException on the native side #4232

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Nov 4, 2024

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Replaces the beforeSend string matching filtering with the addIgnoredExceptionForType initialisation option for ignoring the JavascriptException events and avoid sending them twice. This is enforced on captureEvent in the java SDK which relies on comparing the class. This is not affected by obfuscation like the string value returned by getType().

💡 Motivation and Context

Fixes #3126

💚 How did you test it?

Manual testing with the sample app, passing CI checks

Note: I wasn't able to reproduce the duplicated unhandled JS error on obfuscated code (minifyEnabled, proguard) and only verified that the app behaviour hasn't changed.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filtering duplicated Unhandled JS Errors doesn't work with obfuscated class names on Android
1 participant