Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sample): Remove generated source maps #4218

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

krystofwoldrich
Copy link
Member

#skip-changelog

Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 378.52 ms 428.40 ms 49.88 ms
Size 7.15 MiB 8.35 MiB 1.20 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d43a46b+dirty 417.65 ms 472.98 ms 55.33 ms
d361d38+dirty 257.72 ms 318.76 ms 61.04 ms
0677344+dirty 288.40 ms 391.44 ms 103.04 ms
76d1baf+dirty 339.02 ms 408.65 ms 69.63 ms
15c80ab+dirty 276.38 ms 327.54 ms 51.17 ms
52a8031+dirty 330.72 ms 358.76 ms 28.03 ms
575f9da+dirty 337.15 ms 370.47 ms 33.32 ms
0ebca77+dirty 360.94 ms 402.24 ms 41.30 ms
e2b64fe+dirty 258.82 ms 304.26 ms 45.44 ms
484813b+dirty 411.65 ms 456.02 ms 44.37 ms

App size

Revision Plain With Sentry Diff
d43a46b+dirty 7.15 MiB 8.34 MiB 1.19 MiB
d361d38+dirty 7.15 MiB 8.08 MiB 959.34 KiB
0677344+dirty 7.15 MiB 8.07 MiB 949.80 KiB
76d1baf+dirty 7.15 MiB 8.09 MiB 964.41 KiB
15c80ab+dirty 7.15 MiB 8.09 MiB 966.13 KiB
52a8031+dirty 7.15 MiB 8.09 MiB 965.95 KiB
575f9da+dirty 7.15 MiB 8.10 MiB 979.68 KiB
0ebca77+dirty 7.15 MiB 8.22 MiB 1.07 MiB
e2b64fe+dirty 7.15 MiB 8.07 MiB 947.16 KiB
484813b+dirty 7.15 MiB 8.34 MiB 1.19 MiB

Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1227.24 ms 1226.14 ms -1.10 ms
Size 2.36 MiB 3.08 MiB 735.59 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c2a4e9b+dirty 1240.10 ms 1239.22 ms -0.88 ms
34aba08+dirty 1276.78 ms 1308.52 ms 31.74 ms
b1e8712+dirty 1256.02 ms 1265.14 ms 9.12 ms
70caa60+dirty 1218.27 ms 1230.30 ms 12.03 ms
2534337+dirty 1225.08 ms 1230.26 ms 5.17 ms
e5bc97b+dirty 1230.63 ms 1234.83 ms 4.20 ms
4a6664f+dirty 1209.49 ms 1208.63 ms -0.86 ms
15c80ab+dirty 1223.74 ms 1228.96 ms 5.22 ms
0db0c72+dirty 1275.02 ms 1285.84 ms 10.82 ms
575f9da+dirty 1266.22 ms 1274.84 ms 8.62 ms

App size

Revision Plain With Sentry Diff
c2a4e9b+dirty 2.36 MiB 3.08 MiB 734.00 KiB
34aba08+dirty 2.36 MiB 2.85 MiB 495.32 KiB
b1e8712+dirty 2.36 MiB 2.84 MiB 488.84 KiB
70caa60+dirty 2.36 MiB 2.83 MiB 479.27 KiB
2534337+dirty 2.36 MiB 2.88 MiB 525.47 KiB
e5bc97b+dirty 2.36 MiB 3.10 MiB 753.14 KiB
4a6664f+dirty 2.36 MiB 3.04 MiB 696.39 KiB
15c80ab+dirty 2.36 MiB 2.83 MiB 474.49 KiB
0db0c72+dirty 2.36 MiB 2.84 MiB 487.01 KiB
575f9da+dirty 2.36 MiB 2.87 MiB 520.20 KiB

Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1243.37 ms 1240.80 ms -2.57 ms
Size 2.92 MiB 3.64 MiB 741.22 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c2a4e9b+dirty 1247.39 ms 1243.04 ms -4.35 ms
34aba08+dirty 1268.58 ms 1276.80 ms 8.22 ms
b1e8712+dirty 1284.11 ms 1297.82 ms 13.71 ms
70caa60+dirty 1279.08 ms 1281.54 ms 2.46 ms
2534337+dirty 1220.87 ms 1221.47 ms 0.60 ms
e5bc97b+dirty 1229.17 ms 1227.64 ms -1.54 ms
4a6664f+dirty 1218.77 ms 1221.07 ms 2.30 ms
15c80ab+dirty 1248.41 ms 1251.24 ms 2.83 ms
0db0c72+dirty 1258.88 ms 1262.52 ms 3.64 ms
575f9da+dirty 1272.00 ms 1284.38 ms 12.38 ms

App size

Revision Plain With Sentry Diff
c2a4e9b+dirty 2.92 MiB 3.64 MiB 739.91 KiB
34aba08+dirty 2.92 MiB 3.41 MiB 499.03 KiB
b1e8712+dirty 2.92 MiB 3.40 MiB 494.15 KiB
70caa60+dirty 2.92 MiB 3.39 MiB 486.04 KiB
2534337+dirty 2.92 MiB 3.43 MiB 529.76 KiB
e5bc97b+dirty 2.92 MiB 3.66 MiB 758.40 KiB
4a6664f+dirty 2.92 MiB 3.60 MiB 702.09 KiB
15c80ab+dirty 2.92 MiB 3.39 MiB 481.56 KiB
0db0c72+dirty 2.92 MiB 3.40 MiB 492.71 KiB
575f9da+dirty 2.92 MiB 3.43 MiB 524.26 KiB

@krystofwoldrich krystofwoldrich merged commit 9cd0e9f into main Oct 30, 2024
59 of 61 checks passed
@krystofwoldrich krystofwoldrich deleted the kw/chore/remove-sample-source-map branch October 30, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants