-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: Change native frames from traceId
to spanId
#4030
Merged
krystofwoldrich
merged 9 commits into
v6
from
kw/ref-native-frames-prepare-for-span-measurements
Sep 2, 2024
Merged
ref: Change native frames from traceId
to spanId
#4030
krystofwoldrich
merged 9 commits into
v6
from
kw/ref-native-frames-prepare-for-span-measurements
Sep 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krystofwoldrich
changed the title
Kw/ref-native-frames-prepare-for-span-measurements
ref: Change native frames from Aug 16, 2024
traceId
to spanId
krystofwoldrich
force-pushed
the
kw/ref-native-frames-prepare-for-span-measurements
branch
from
August 16, 2024 11:01
463da28
to
5713f87
Compare
Android (legacy) Performance metrics 🚀
|
iOS (legacy) Performance metrics 🚀
|
iOS (new) Performance metrics 🚀
|
Android (new) Performance metrics 🚀
|
lucas-zimerman
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking questions and also some minor suggestions. Let me know if you need more reviews.
…github.com:getsentry/sentry-react-native into kw/ref-native-frames-prepare-for-span-measurements
krystofwoldrich
deleted the
kw/ref-native-frames-prepare-for-span-measurements
branch
September 2, 2024 14:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This PR changes the native frames from attaching to
traceId
which can be the same for multiple spans tospanId
.💚 How did you test it?
sample app, unit tests
📝 Checklist
sendDefaultPII
is enabled