fix(tracing): Update warm/cold start span ops #2487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be more consistent with Cocoa and Android, update the span ops to use `.` instead of `_` seperators. This matches the pattern we use for the rest of the span ops also
AbhiPrasad
requested review from
marandaneto and
krystofwoldrich
as code owners
6 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Update from
app_start_warm->app.start.warmandapp_start_cold->app.start.cold💡 Motivation and Context
To be more consistent with Cocoa and Android, update the span ops to use
.instead of_seperators. This matches the pattern we use for the rest of the span ops also.Cocoa: https://github.com/getsentry/sentry-cocoa/blob/91fc76f19bce100895028b52f642469698cd90ae/Sources/Sentry/SentryTracer.m#L635
Android: https://github.com/getsentry/sentry-java/blob/e2ea31c73c93aa587941cb7ea9254f853786db26/sentry-android-core/src/main/java/io/sentry/android/core/ActivityLifecycleIntegration.java#L42
See: https://www.notion.so/sentry/Set-up-an-audit-for-SDK-consistency-for-span-operations-to-enable-performance-issues-addf02a8fa234dda8acf48d4ff9b8efb
💚 How did you test it?
Updated tests
📝 Checklist
🔮 Next steps