Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Auto linking for RN >= 0.69 #2332

Merged
merged 7 commits into from
Jul 22, 2022
Merged

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Jun 30, 2022

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Remove the removed config from the config file.
This is a breaking change.

💡 Motivation and Context

Fixes #2267

💚 How did you test it?

Running it

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

Patch https://github.com/getsentry/sentry-wizard

@marandaneto
Copy link
Contributor Author

@bruno-garcia What if we say that the RN SDK 5.x requires RN version >= 0.69?
We could technically drop stuff like #2015
It'd be easier to maintain as well since we don't need to test stuff on older versions, we'd need to patch bug fixes on v4.x when needed though.
Ideally not the best solution for the user, but this is a breaking change and auto-linking won't work for either before or after 0.69.

@bruno-garcia
Copy link
Member

bruno-garcia commented Jun 30, 2022

Sounds like it's it's time. Can we spit out build warnings/errors in case the expected version doesn't match? My biggest worry is of users getting unrelated error messages, being frustrated and/or raising issues with support.

If we can break at build time, with:

Sentry 5.0 on older RN: The Sentry SDK version 5.0.0 and above requires React Native 0.69 or higher
Sentry 4.x on older RN: The Sentry SDK version 4 doesn't support React Native 0.69. Please upgrade to Sentry 5.0.0 or higher

@marandaneto marandaneto marked this pull request as ready for review July 21, 2022 06:59
@marandaneto
Copy link
Contributor Author

TODO: yarn install after sentry-wizard gets released to update the yarn.lock file.

@marandaneto marandaneto changed the base branch from main to 5.0.0 July 22, 2022 08:47
@marandaneto marandaneto merged commit 3e864f9 into 5.0.0 Jul 22, 2022
@marandaneto marandaneto deleted the chore/rn0-69-autolinking branch July 22, 2022 11:21
@Acetyld
Copy link
Contributor

Acetyld commented Oct 31, 2022

Any idea on release date?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autolinking broken in 0.69
4 participants