misc(tracing): Remove ReactNativeTracing deprecated options

getsentry · Aug 6, 2024 · 4f3ca7b · 4f3ca7b
1 parent 89b2354
commit 4f3ca7b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 63 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,8 @@
 
 ### Changes
 
+- Removed deprecated ReactNativeTracing option `idleTimeout` use `idleTimeoutMs` instead([#3998](https://github.com/getsentry/sentry-react-native/pull/3998))
+- Removed deprecated ReactNativeTracing option `maxTransactionDuration` use `finalTimeoutMs` instead([#3998](https://github.com/getsentry/sentry-react-native/pull/3998))
 - New Native Frames Integration ([#3996](https://github.com/getsentry/sentry-react-native/pull/3996))
 - New Stall Tracking Integration ([#3997](https://github.com/getsentry/sentry-react-native/pull/3997))
 - New App Start Integration ([#3852](https://github.com/getsentry/sentry-react-native/pull/3852))

diff --git a/src/js/tracing/reactnativetracing.ts b/src/js/tracing/reactnativetracing.ts
@@ -98,8 +98,6 @@ const DEFAULT_TRACE_PROPAGATION_TARGETS = ['localhost', /^\/(?!\/)/];
 
 const defaultReactNativeTracingOptions: ReactNativeTracingOptions = {
   ...defaultRequestInstrumentationOptions,
-  idleTimeout: 1000,
-  maxTransactionDuration: 600,
   idleTimeoutMs: 1000,
   finalTimeoutMs: 600000,
   ignoreEmptyBackNavigationTransactions: true,
@@ -143,19 +141,8 @@ export class ReactNativeTracing implements Integration {
     this.options = {
       ...defaultReactNativeTracingOptions,
       ...options,
-      finalTimeoutMs:
-        options.finalTimeoutMs ??
-        // eslint-disable-next-line deprecation/deprecation
-        (typeof options.maxTransactionDuration === 'number'
-          ? // eslint-disable-next-line deprecation/deprecation
-            options.maxTransactionDuration * 1000
-          : undefined) ??
-        defaultReactNativeTracingOptions.finalTimeoutMs,
-      idleTimeoutMs:
-        options.idleTimeoutMs ??
-        // eslint-disable-next-line deprecation/deprecation
-        options.idleTimeout ??
-        defaultReactNativeTracingOptions.idleTimeoutMs,
+      finalTimeoutMs: options.finalTimeoutMs ?? defaultReactNativeTracingOptions.finalTimeoutMs,
+      idleTimeoutMs: options.idleTimeoutMs ?? defaultReactNativeTracingOptions.idleTimeoutMs,
     };
   }
 

diff --git a/test/tracing/reactnativetracing.test.ts b/test/tracing/reactnativetracing.test.ts
@@ -292,54 +292,6 @@ describe('ReactNativeTracing', () => {
       });
     });
   });
-  describe('Handling deprecated options', () => {
-    test('finalTimeoutMs overrides maxTransactionDuration', () => {
-      const tracing = new ReactNativeTracing({
-        finalTimeoutMs: 123000,
-        maxTransactionDuration: 456,
-      });
-      expect(tracing.options.finalTimeoutMs).toBe(123000);
-      // eslint-disable-next-line deprecation/deprecation
-      expect(tracing.options.maxTransactionDuration).toBe(456);
-    });
-    test('maxTransactionDuration translates to finalTimeoutMs', () => {
-      const tracing = new ReactNativeTracing({
-        maxTransactionDuration: 123,
-      });
-      expect(tracing.options.finalTimeoutMs).toBe(123000);
-      // eslint-disable-next-line deprecation/deprecation
-      expect(tracing.options.maxTransactionDuration).toBe(123);
-    });
-    test('if none maxTransactionDuration and finalTimeoutMs is specified use default', () => {
-      const tracing = new ReactNativeTracing({});
-      expect(tracing.options.finalTimeoutMs).toBe(600000);
-      // eslint-disable-next-line deprecation/deprecation
-      expect(tracing.options.maxTransactionDuration).toBe(600);
-    });
-    test('idleTimeoutMs overrides idleTimeout', () => {
-      const tracing = new ReactNativeTracing({
-        idleTimeoutMs: 123,
-        idleTimeout: 456,
-      });
-      expect(tracing.options.idleTimeoutMs).toBe(123);
-      // eslint-disable-next-line deprecation/deprecation
-      expect(tracing.options.idleTimeout).toBe(456);
-    });
-    test('idleTimeout translates to idleTimeoutMs', () => {
-      const tracing = new ReactNativeTracing({
-        idleTimeout: 123,
-      });
-      expect(tracing.options.idleTimeoutMs).toBe(123);
-      // eslint-disable-next-line deprecation/deprecation
-      expect(tracing.options.idleTimeout).toBe(123);
-    });
-    test('if none idleTimeout and idleTimeoutMs is specified use default', () => {
-      const tracing = new ReactNativeTracing({});
-      expect(tracing.options.idleTimeoutMs).toBe(1000);
-      // eslint-disable-next-line deprecation/deprecation
-      expect(tracing.options.idleTimeout).toBe(1000);
-    });
-  });
 
   describe('User Interaction Tracing', () => {
     let client: TestClient;