fix(openai-agents): Isolate agent run#4720
Merged
sentrivana merged 5 commits intomasterfrom Aug 26, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4720 +/- ##
==========================================
+ Coverage 84.84% 84.87% +0.03%
==========================================
Files 156 156
Lines 16109 16110 +1
Branches 2740 2740
==========================================
+ Hits 13667 13673 +6
+ Misses 1655 1650 -5
Partials 787 787
|
sl0thentr0py
approved these changes
Aug 26, 2025
Member
sl0thentr0py
left a comment
There was a problem hiding this comment.
change looks ok in itself, don't have context on the whole integration
This was referenced Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like we're running into #4718 (and probably #4690) because the different agent runs are not properly isolated. This only seems to be a problem when multiple agent runs are awaited at once (e.g. via
asyncio.gather) -- it seems that leads to some scope bleed.