Skip to content

feat(logs): Add user attributes to logs #4423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions sentry_sdk/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -927,6 +927,20 @@ def _capture_experimental_log(self, current_scope, log):
elif propagation_context is not None:
log["trace_id"] = propagation_context.trace_id

if self.should_send_default_pii() and isolation_scope._user is not None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we also check the global and current scope?

for log_attribute, user_attribute in (
("user.id", "id"),
("user.name", "username"),
("user.email", "email"),
):
if (
user_attribute in isolation_scope._user
and log_attribute not in log["attributes"]
):
log["attributes"][log_attribute] = isolation_scope._user[
user_attribute
]

# If debug is enabled, log the log to the console
debug = self.options.get("debug", False)
if debug:
Expand Down
43 changes: 43 additions & 0 deletions tests/test_logs.py
Original file line number Diff line number Diff line change
Expand Up @@ -484,6 +484,49 @@ def test_auto_flush_logs_after_100(sentry_init, capture_envelopes):
raise AssertionError("200 logs were never flushed after five seconds")


def test_user_attributes(sentry_init, capture_envelopes):
"""User attributes are sent if send_default_pii is True."""
sentry_init(send_default_pii=True, _experiments={"enable_logs": True})

sentry_sdk.set_user({"id": "1", "email": "test@example.com", "username": "test"})
envelopes = capture_envelopes()

python_logger = logging.Logger("test-logger")
python_logger.warning("Hello, world!")

get_client().flush()

logs = envelopes_to_logs(envelopes)
(log,) = logs

# Check that all expected user attributes are present.
assert log["attributes"].items() >= {
("user.id", "1"),
("user.email", "test@example.com"),
("user.name", "test"),
}


def test_user_attributes_no_pii(sentry_init, capture_envelopes):
"""Ensure no user attributes are sent if send_default_pii is False."""
sentry_init(_experiments={"enable_logs": True})

sentry_sdk.set_user({"id": "1", "email": "test@example.com", "username": "test"})
envelopes = capture_envelopes()

python_logger = logging.Logger("test-logger")
python_logger.warning("Hello, world!")

get_client().flush()

logs = envelopes_to_logs(envelopes)

(log,) = logs
assert "user.id" not in log["attributes"]
assert "user.email" not in log["attributes"]
assert "user.name" not in log["attributes"]


@minimum_python_37
def test_auto_flush_logs_after_5s(sentry_init, capture_envelopes):
"""
Expand Down
Loading