Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(profiling): Reduce continuous profiling test flakiness #4052

Merged

Conversation

Zylphrex
Copy link
Member

Not too sure what the problem is exactly but my suspicion is that the profiler runs in a separate thread and needs time to flush the chunk, the test wasn't waiting long enough.

Not too sure what the problem is exactly but my suspicion is that the profiler
runs in a separate thread and needs time to flush the chunk, the test wasn't
waiting long enough.
@Zylphrex Zylphrex requested a review from sentrivana February 13, 2025 13:30
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.32%. Comparing base (2b067e9) to head (1e280dd).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4052   +/-   ##
=======================================
  Coverage   80.32%   80.32%           
=======================================
  Files         140      140           
  Lines       15510    15510           
  Branches     2628     2628           
=======================================
  Hits        12459    12459           
+ Misses       2210     2209    -1     
- Partials      841      842    +1     

see 2 files with indirect coverage changes

@sentrivana sentrivana merged commit 7c9f402 into master Feb 13, 2025
151 checks passed
@sentrivana sentrivana deleted the txiao/tests/reduce-flakiness-of-continuous-profiling-tests branch February 13, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants