ref(celery): remove deprecated propagate_traces option
#3725
+3
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`propagate_traces` is not documented and superseded by `trace_propagation_targets`. Refs getsentry#3106
|
Hey @nellaG, thanks for the contribution! As this has to go out in a Major (it will be part in SDK 3.0) this will stay around for some while until we are ready to prepare 3.0. So I guess this will happen somewhen in spring 2025. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
propagate_tracesis not documented and superseded bytrace_propagation_targets.Refs #3106
Hello! I found this issue through the Hacktoberfest tag. This PR removes all instances of the propagate_traces option, as described in the issue title.
Thank you for contributing to
sentry-python! Please add tests to validate your changes, and lint your code usingtox -e linters.Running the test suite on your PR might require maintainer approval. The AWS Lambda tests additionally require a maintainer to add a special label, and they will fail until this label is added.