Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto enable Litestar integration #3540

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Conversation

provinzkraut
Copy link
Contributor

Auto enable the Litestar integration added in #3358.


Thank you for contributing to sentry-python! Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. The AWS Lambda tests additionally require a maintainer to add a special label, and they will fail until this label is added.

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.90%. Comparing base (e9ec6c1) to head (38cbfdc).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3540      +/-   ##
==========================================
+ Coverage   79.89%   79.90%   +0.01%     
==========================================
  Files         137      137              
  Lines       15373    15373              
  Branches     2609     2609              
==========================================
+ Hits        12282    12284       +2     
+ Misses       2221     2219       -2     
  Partials      870      870              
Files with missing lines Coverage Δ
sentry_sdk/integrations/__init__.py 81.81% <ø> (ø)

... and 1 file with indirect coverage changes

@sentrivana
Copy link
Contributor

Hey @provinzkraut, thanks for the PR -- we can merge this once the Litestar integration has been available for some time. I'd wait for couple more releases. We also have a new major coming up soonish (probably still this year) so if we don't enable the integration until then, SDK 3.0 would be a good point to do it.

@antonpirker antonpirker added the Trigger: tests using secrets PR code is safe; run CI label Nov 21, 2024
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some time has passed and there were no bug reports about the Litestar integration, so we can auto enable it.

@antonpirker antonpirker enabled auto-merge (squash) November 21, 2024 11:52
@antonpirker antonpirker self-assigned this Nov 21, 2024
@antonpirker antonpirker merged commit 295dd8d into getsentry:master Nov 21, 2024
136 of 138 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Trigger: tests using secrets PR code is safe; run CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants