Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(django): Add sync_capable to SentryWrappingMiddleware #3510

Merged
merged 3 commits into from
Sep 11, 2024
Merged

fix(django): Add sync_capable to SentryWrappingMiddleware #3510

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f19214
fix(django): Add `sync_capable` to `SentryWrappingMiddleware`
szokeasaurusrex Sep 9, 2024
35a1388
test(django): Test that `sync_capable` set on wrapped middleware
szokeasaurusrex Sep 10, 2024
2c6e450
Merge branch 'master' into szokeasaurusrex/django-sync_capable
szokeasaurusrex Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sentry_sdk/integrations/django/middleware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ def sentry_wrapped_method(*args, **kwargs):
class SentryWrappingMiddleware(
_asgi_middleware_mixin_factory(_check_middleware_span) # type: ignore
):
sync_capable = getattr(middleware, "sync_capable", True)
async_capable = DJANGO_SUPPORTS_ASYNC_MIDDLEWARE and getattr(
middleware, "async_capable", False
)
Expand Down
Loading