-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix non-UTC timestamps #3461
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 4 Tests Failed:
View the top 3 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
sl0thentr0py
approved these changes
Aug 26, 2024
Looks like this maybe does not work on Python <3.12 |
Yeah, seems that |
sentrivana
reviewed
Aug 27, 2024
szokeasaurusrex
force-pushed
the
szokeasaurusrex/fix-timestamps
branch
2 times, most recently
from
August 27, 2024 09:28
a456a68
to
d7669f9
Compare
sentrivana
reviewed
Aug 27, 2024
sentrivana
reviewed
Aug 27, 2024
szokeasaurusrex
force-pushed
the
szokeasaurusrex/fix-timestamps
branch
from
August 27, 2024 09:43
d7669f9
to
efc8e56
Compare
sentrivana
approved these changes
Aug 27, 2024
szokeasaurusrex
force-pushed
the
szokeasaurusrex/fix-timestamps
branch
from
August 27, 2024 10:55
efc8e56
to
79e04c4
Compare
Fixes a bug where all `datetime` timestamps in an event payload were serialized as if they were UTC timestamps, even if they were non-UTC timestamps, completely ignoring the timezone. Now, we convert all datetime objects to UTC before formatting them as a UTC timestamp. Fixes #3453
szokeasaurusrex
force-pushed
the
szokeasaurusrex/fix-timestamps
branch
from
August 27, 2024 10:55
79e04c4
to
99be567
Compare
arjennienhuis
pushed a commit
to arjennienhuis/sentry-python
that referenced
this pull request
Sep 30, 2024
Fixes a bug where all `datetime` timestamps in an event payload were serialized as if they were UTC timestamps, even if they were non-UTC timestamps, completely ignoring the timezone. Now, we convert all datetime objects to UTC before formatting them as a UTC timestamp. Fixes getsentry#3453
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where all
datetime
timestamps in an event payload were serialized as if they were UTC timestamps, even if they were non-UTC timestamps, completely ignoring the timezone. Now, we convert all datetime objects to UTC before formatting them as a UTC timestamp.Fixes #3453.