-
Notifications
You must be signed in to change notification settings - Fork 555
Remove outdated pins #2690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove outdated pins #2690
Conversation
I just ran the tests locally and there is no error. Just the |
Yeah this. Also works for me locally. Interestingly, it only fails on 3.12, but it's not some dependency issue because it installs the same versions of the same dependencies on both 3.11 (where it's working) and 3.12. Will try to bisect a bit what is causing this. |
I just messed around with the Django tests. The problem is the following:
And my guess now is that when two test suites run at the same time they both want to fill the db by running the migrations and because there is already something in the db, it fails with the And as so often when fixing bugs the question is: How has this ever worked at some point? :-) Solution would now be to either have one postgres server by test suite, or one unique database name per test suite. (or maybe create the postgres server in some completely different way) |
I played around more and have this: https://github.com/getsentry/sentry-python/actions/runs/8572070273/job/23493776173?pr=2938 The thing now is that in "Setup Test Env" i try to delete the uniquely named db name but it does not exist. (which is fine) Two steps later when running the django tests they fail becaus the db is already existing. So the db is not cleaned up between running different django versions in one call to tox. Not sure why, but this is something for future Anton! |
@antonpirker Maybe this can be somehow combined with
|
I think I have solved the problem now in my PR: #2938 |
Ok, the Python 3.12 tests still freeze, but the rest is green so I will merge it into here. |
Awesome! The Web Frameworks 1 tests on 3.12 will still time out but that's not a problem with your PR. Everything else seems green so feel free to merge |
Make sure the Django tests are always run with a unique database name that is cleaned up after the tests have been run.
Regarding the freezing 3.12 tests: the problem goes away as soon as you remove |
Marking this as ready for review but we shouldn't merge this until the final release is out. |
Remove version pins on tools that are no longer necessary.
Relates #2586
General Notes
Thank you for contributing to
sentry-python
!Please add tests to validate your changes, and lint your code using
tox -e linters
.Running the test suite on your PR might require maintainer approval. Some tests (AWS Lambda) additionally require a maintainer to add a special label to run and will fail if the label is not present.
For maintainers
Sensitive test suites require maintainer review to ensure that tests do not compromise our secrets. This review must be repeated after any code revisions.
Before running sensitive test suites, please carefully check the PR. Then, apply the
Trigger: tests using secrets
label. The label will be removed after any code changes to enforce our policy requiring maintainers to review all code revisions before running sensitive tests.