Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarified the procedure for running tests #2276

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Clarified the procedure for running tests #2276

merged 2 commits into from
Jul 28, 2023

Conversation

szokeasaurusrex
Copy link
Member

Fixes #2275

@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review July 27, 2023 15:19
sentrivana
sentrivana approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I'm looking into fixing the failing tests in another PR, so once that is merged, we can rebase this PR and the tests should be green here too.

@szokeasaurusrex szokeasaurusrex enabled auto-merge (squash) July 28, 2023 12:56
@szokeasaurusrex szokeasaurusrex merged commit b719952 into master Jul 28, 2023
245 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/clarifying-contribution-instructions branch July 28, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sentrivana sentrivana sentrivana approved these changes

@antonpirker antonpirker Awaiting requested review from antonpirker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarify instructions for running tests in CONTRIBUTING.md
2 participants
@szokeasaurusrex @sentrivana