Skip to content

feat(redis): Add support for redis.asyncio #1933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Jul 11, 2023
Merged

feat(redis): Add support for redis.asyncio #1933

merged 26 commits into from
Jul 11, 2023

Conversation

Zhenay
Copy link
Contributor

@Zhenay Zhenay commented Mar 1, 2023

See #931

@Zhenay Zhenay force-pushed the Zhenay/931-redis-asyncio branch from 647884f to 7539af7 Compare March 1, 2023 16:19
@github-actions
Copy link

github-actions bot commented Apr 8, 2023

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@smeubank smeubank mentioned this pull request Jun 13, 2023
Closed
@antonpirker antonpirker self-assigned this Jul 10, 2023
antonpirker
antonpirker reviewed Jul 10, 2023
View reviewed changes
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. Will do some manual testing now.

@antonpirker
Copy link
Member

I added the PII scrubbing function for pipeline commands that we had in place at another place already, for not leaking PII accidentally

antonpirker
antonpirker approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and does what it should. Ready for shipping this!

@antonpirker
Copy link
Member

Hey @Zhenay !

It took some time, but finally your contribution can be merged! Thank you so much for this contribution, really cool stuff!

When the tests are finished and green this will be merged!
If you send me you shipping address and your t-shirt size I try to get you a tshirt (I say "try" because in the past is turned out quite complicated to impossible to ship stuff to certain countries) Send it to anton.pirker@sentry.io

Thank you!

@antonpirker antonpirker enabled auto-merge (squash) July 11, 2023 08:53
@antonpirker antonpirker merged commit 994a45b into getsentry:master Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonpirker antonpirker antonpirker approved these changes

Assignees

@antonpirker antonpirker

Labels
Integration: Redis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zhenay @antonpirker