Skip to content

Better setting of in-app in stack frames #1894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Feb 15, 2023
Merged

Better setting of in-app in stack frames #1894

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
809b29d
Better setting of in-app
antonpirker Feb 10, 2023
b8263b2
Fixed tests
antonpirker Feb 10, 2023
ad07e1a
Handling if abs_path is not present in frame
antonpirker Feb 10, 2023
d97a478
Added debug output
antonpirker Feb 10, 2023
341c349
Removed debug output and check for in_app because this test is about …
antonpirker Feb 10, 2023
5bbc1bb
Just set in_app if we are sure it is an external source
antonpirker Feb 10, 2023
4ae95f6
Fixed tests
antonpirker Feb 10, 2023
dc3872d
Check if frame is in project root directory and if yes set in_app to …
antonpirker Feb 10, 2023
7c7355a
Merge branch 'master' into antonpirker/1754-in-app
antonpirker Feb 10, 2023
7a2e3b5
Made function more readable
antonpirker Feb 11, 2023
ecb1fd7
Better name of function
antonpirker Feb 11, 2023
707b440
Merge branch 'master' into antonpirker/1754-in-app
antonpirker Feb 15, 2023
905320e
Moved project_root configuration into options
antonpirker Feb 15, 2023
2b80b5d
Removed check because in_app is now not always set
antonpirker Feb 15, 2023
34b8e3b
Only fetching working directory when not already set.
antonpirker Feb 15, 2023
4a7c31a
Added type annotations
antonpirker Feb 15, 2023
10e57a5
Added project_root to the default options
antonpirker Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Only fetching working directory when not already set.
  • Loading branch information
@antonpirker
antonpirker committed Feb 15, 2023
commit 34b8e3baedf40a7af6f56a53f290d3bfcaa5caed
11 changes: 6 additions & 5 deletions sentry_sdk/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,12 +90,13 @@ def _get_options(*args, **kwargs):
if rv["instrumenter"] is None:
rv["instrumenter"] = INSTRUMENTER.SENTRY

try:
project_root = os.getcwd()
except Exception:
project_root = None
if rv["project_root"] is None:
try:
project_root = os.getcwd()
except Exception:
project_root = None

rv["project_root"] = project_root
rv["project_root"] = project_root

return rv

Expand Down