🐛 Fix detection of contextvars compatibility with Gevent 20.9.0+ #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
approved these changes
Jul 27, 2021
ahmedetefy
approved these changes
Jul 27, 2021
|
Thanks for the reviews @untitaker and @ahmedetefy! 🚀 Dang it, sorry for the linter warnings, I just ran them locally and fixed them (hopefully 🤞). I agree that all the extra complexity for testing different versions of Gevent with different versions of Python doesn't seem worth it as it's probably more of an edge case. Nevertheless, let me know if they are needed and I can give that a try. |
|
Thanks @tiangolo ! |
|
Awesome! Thanks for the quick response/review and merge! 🚀 Do you have any estimate of when this could be included in a release? |
|
Anytime! Yep will cut a patch today |
|
Woohoo! Awesome, thanks a lot! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Fix detection of contextvars compatibility with Gevent 20.9.0+
This is described in #1063, and this PR would fix it (it should at least).
Description
The current implementation checks if Gevent patched contextvars, but:
Ref: https://github.com/gevent/gevent/blob/83c9e2ae5b0834b8f84233760aabe82c3ba065b4/src/gevent/monkey.py#L604-L609
This PR updates the implementation to check the version of Gevent and Python to account for that.
Use Case
I'm migrating a code base with a couple of apps from Flask to FastAPI. During the migration both Flask and FastAPI are available at the same time, sharing a lot of the code and tests.
The Flask app is currently deployed with Gevent, so the tests use Gevent's monkey patching.
The FastAPI app uses the
SentryAsgiMiddleware, which internally usescontextvarsto store and handle all the Sentry stuff per request. And that in turn uses this utility function to check if the current environment has working contextvars available.So, with Python 3.7+ and a recent installation of Gevent monkey patching stuff, Sentry errors out complaining about broken contextvars, but it seems it's actually just a false positive.