Notes for Django

[dcramer]

• Probably should try to find an earlier entry point other than settings.py (but I'm out of touch w/ Django's load process)
• sentry_sdk.init is better than init on our suggest import process

Test Plan:

• catches wsgi error?
• catches manage.py error?
• catches sys.except_hook (non manage.py) error?
• catches middleware error?
• catches view error?

[dcramer]

Also a note that it 100% doesnt work with native graphene integration (as they hijack error handling in a not-so-great kind of way).

[dcramer]

class EnhancedGraphQLView(GraphQLView):
    @staticmethod
    def format_error(error):
        sentry_sdk.capture_exception()
        return GraphQLView.format_error(error)

[untitaker]

manage.py is not handled by excepthook, django catches exceptions. Need to patch django again

[untitaker]

raw wsgi errors are not caught at all. I think this needs more thought, especially wrt how to deduplicate code between Flask and Django. I'd like to attach parts of the environ but then I duplicate already existing functionality that operates on request objects.

In the long term I suspect we will have to convert everything to a WSGI middleware and do our own request parsing.

[untitaker]

Follow-up issues have been created