ref(rate-limit): handle profile and check_in rate limiting#1970
Merged
ref(rate-limit): handle profile and check_in rate limiting#1970
Conversation
14 tasks
stayallive
approved these changes
Nov 20, 2025
Contributor
Author
I was thinking about this but profiles need to be removed from transaction and I didn't want to introduce mutation in the |
Collaborator
|
Hmm, yes that does make sense (not mutating the event in the rate limiter). Okay then let's roll with this and update this later if we find a better solution for re-use. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds rate limiting for
profileand adds mapping fromcheck_in=>monitorto properly handlecheck_inrate limits.Definitions for data categories are located here: https://develop.sentry.dev/sdk/expected-features/rate-limiting/#definitions
closes PHP-54