Conversation
# Conflicts: # composer.json
Contributor
|
The bridge is needed for the ClockMock. Also, it's useful to detect deprecations, but in newer PHPUnit versions (10+) that could be handled natively. |
Member
|
Our entire CI broke because of changes in the bridge. We can vendor in the ClockMock and move on. |
Contributor
Author
As far as I can see we don't use this |
Contributor
You do: Lines 10 to 12 in 1895ab6 See docs for usage: https://symfony.com/doc/current/components/phpunit_bridge.html#making-tests-fail Since you still need to support older PHP versions, doing otherwise with PHPUnit 10+ is not a viable solution. |
cleptric
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Replaces Symfony PHPUnit Bridge/ClockMock with a new internal
Sentry\Util\ClockMock, updates tests accordingly, and adjusts static analysis and PHPUnit config.Symfony\Bridge\PhpUnit\ClockMockwith internalSentry\Util\ClockMockacross tests andtests/bootstrap.php(adds additionalClockMock::register(...), incl.Sentry\Serializer\PayloadSerializer).Symfony\Bridge\PhpUnit\ExpectDeprecationTraitusages from tests.src/Util/ClockMock.php(ported clock mocking functions) used by tests.symfony/phpunit-bridgefromrequire-devand drop PHPUnit<listeners>fromphpunit.xml.dist.src/Util/ClockMock.phpfrom analyzers (phpstan.neonexcludePaths,psalm.xml.distignoreFiles).Written by Cursor Bugbot for commit ee9440a. This will update automatically on new commits. Configure here.
Removes the
symfony/phpunit-bridgedependency in favour of a vendoredClockMockclass from said dependency. The motivation behind this is that a change in the bridge broke our pipeline and we only really use theClockMockfrom the package.