ref(logs): implement __destruct to make sure logs are always flushed#1916
Merged
ref(logs): implement __destruct to make sure logs are always flushed#1916
Conversation
stayallive
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates theLogsHandlerto extent\Monolog\Handler\Handlerso that we inherit the__destructmethod which will flush when being destructed.Implements
__destructmanually to make sure that logs are always flushed once the handler is destructed.This will make sure that no logs are lost in case calling
flush()is forgotten.We cannot use
\Monolog\Handler\Handlerbecause it is not available for the lowest version of monolog we support.resolves #1915
closes PHP-33