Skip to content

Comments

ref: remove @internal annotation from Result#1904

Merged
cleptric merged 2 commits intomasterfrom
martinl/remove-internal-from-result
Sep 15, 2025
Merged

ref: remove @internal annotation from Result#1904
cleptric merged 2 commits intomasterfrom
martinl/remove-internal-from-result

Conversation

@Litarnus
Copy link
Contributor

@Litarnus Litarnus commented Sep 15, 2025

Removes the @internal annotation from Sentry\Transport\Result as it would lead to linter errors when implementing a custom Transport using Sentry\Transport\TransportInterface.

closes #1894
closes PHP-23

@linear
Copy link

linear bot commented Sep 15, 2025

@Litarnus Litarnus marked this pull request as ready for review September 15, 2025 07:52
@Litarnus Litarnus requested a review from cleptric September 15, 2025 08:40
@Litarnus Litarnus self-assigned this Sep 15, 2025
@cleptric cleptric enabled auto-merge (squash) September 15, 2025 09:05
@cleptric cleptric merged commit 80692c6 into master Sep 15, 2025
39 checks passed
@cleptric cleptric deleted the martinl/remove-internal-from-result branch September 15, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sentry\Transport\Result should not be internal as it is part of an interface

2 participants