-
-
Notifications
You must be signed in to change notification settings - Fork 462
Add support for Symfony 8 #1895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Is it possible to disclose the linked issue about environment variables? |
|
@garak Sure, it refers to this issue: getsentry/sentry-symfony#883 Not sure why it got linked here, I think the linear bot got confused |
|
That issue could not be related to Symfony 8. It was opened more than a year ago, when development for Symfony 8 had yet to begin. |
|
SYMFONY-8 from the issue linked above just refers to the ticket number and is not related to Symfony version 8, it was just a coincidence :D |
|
So why the issue is linked? |
|
Probably because the bot made a mistake and postet it here by accident |
|
One last question: is there something preventing this PR from being merged? |
|
Symfony 8 is now in beta. Would it be possible to merge this PR? |
| "psr/log": "^1.0|^2.0|^3.0", | ||
| "symfony/options-resolver": "^4.4.30|^5.0.11|^6.0|^7.0" | ||
| "symfony/options-resolver": "^4.4.30|^5.0.11|^6.0|^7.0|^8.0" | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The composer.json PHP requirement ^7.2|^8.0 is incompatible with Symfony 8.0's options-resolver requiring PHP 8.2+.
Severity: CRITICAL | Confidence: 1.00
🔍 Detailed Analysis
The composer.json declares a PHP requirement of ^7.2|^8.0, allowing PHP versions from 7.2 up to 8.x. However, the symfony/options-resolver: ^8.0 dependency, introduced by this change, requires PHP 8.2 or higher. This creates an incompatible constraint. Users on PHP 8.0 or 8.1 will either encounter dependency resolution failures during composer install or experience runtime errors when the SDK attempts to use OptionsResolver if installation somehow succeeds.
💡 Suggested Fix
Update the composer.json PHP requirement to `
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: composer.json#L33
Potential issue: The `composer.json` declares a PHP requirement of `^7.2|^8.0`, allowing
PHP versions from 7.2 up to 8.x. However, the `symfony/options-resolver: ^8.0`
dependency, introduced by this change, requires PHP 8.2 or higher. This creates an
incompatible constraint. Users on PHP 8.0 or 8.1 will either encounter dependency
resolution failures during `composer install` or experience runtime errors when the SDK
attempts to use `OptionsResolver` if installation somehow succeeds.
Did we get this right? 👍 / 👎 to inform future reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is completely wrong. The AI doesn't understand how semantic versioning works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, 100% agreed
|
@garak we will probably do a release in the next few days |
Closes #1880