Skip to content

Conversation

@cleptric
Copy link
Member

Closes #1880

@linear
Copy link

linear bot commented Sep 11, 2025

@cleptric cleptric self-assigned this Sep 11, 2025
@cleptric cleptric marked this pull request as ready for review September 11, 2025 10:52
@cleptric cleptric marked this pull request as draft September 15, 2025 09:06
@garak
Copy link

garak commented Oct 7, 2025

Is it possible to disclose the linked issue about environment variables?

@Litarnus
Copy link
Contributor

Litarnus commented Oct 8, 2025

@garak Sure, it refers to this issue: getsentry/sentry-symfony#883

Not sure why it got linked here, I think the linear bot got confused

@garak
Copy link

garak commented Oct 8, 2025

That issue could not be related to Symfony 8. It was opened more than a year ago, when development for Symfony 8 had yet to begin.

@Litarnus
Copy link
Contributor

Litarnus commented Oct 8, 2025

SYMFONY-8 from the issue linked above just refers to the ticket number and is not related to Symfony version 8, it was just a coincidence :D

@garak
Copy link

garak commented Oct 8, 2025

So why the issue is linked?

@Litarnus
Copy link
Contributor

Litarnus commented Oct 9, 2025

Probably because the bot made a mistake and postet it here by accident

@garak
Copy link

garak commented Oct 9, 2025

One last question: is there something preventing this PR from being merged?

@cleptric cleptric assigned Litarnus and unassigned cleptric Oct 14, 2025
@garak
Copy link

garak commented Oct 28, 2025

Symfony 8 is now in beta. Would it be possible to merge this PR?

@Litarnus Litarnus marked this pull request as ready for review October 28, 2025 15:19
"psr/log": "^1.0|^2.0|^3.0",
"symfony/options-resolver": "^4.4.30|^5.0.11|^6.0|^7.0"
"symfony/options-resolver": "^4.4.30|^5.0.11|^6.0|^7.0|^8.0"
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The composer.json PHP requirement ^7.2|^8.0 is incompatible with Symfony 8.0's options-resolver requiring PHP 8.2+.
Severity: CRITICAL | Confidence: 1.00

🔍 Detailed Analysis

The composer.json declares a PHP requirement of ^7.2|^8.0, allowing PHP versions from 7.2 up to 8.x. However, the symfony/options-resolver: ^8.0 dependency, introduced by this change, requires PHP 8.2 or higher. This creates an incompatible constraint. Users on PHP 8.0 or 8.1 will either encounter dependency resolution failures during composer install or experience runtime errors when the SDK attempts to use OptionsResolver if installation somehow succeeds.

💡 Suggested Fix

Update the composer.json PHP requirement to `

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: composer.json#L33

Potential issue: The `composer.json` declares a PHP requirement of `^7.2|^8.0`, allowing
PHP versions from 7.2 up to 8.x. However, the `symfony/options-resolver: ^8.0`
dependency, introduced by this change, requires PHP 8.2 or higher. This creates an
incompatible constraint. Users on PHP 8.0 or 8.1 will either encounter dependency
resolution failures during `composer install` or experience runtime errors when the SDK
attempts to use `OptionsResolver` if installation somehow succeeds.

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is completely wrong. The AI doesn't understand how semantic versioning works.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, 100% agreed

@Litarnus Litarnus merged commit 6df603d into master Oct 28, 2025
39 checks passed
@Litarnus Litarnus deleted the add-symfony-8-support branch October 28, 2025 15:29
@Litarnus
Copy link
Contributor

@garak we will probably do a release in the next few days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow Symfony 8

4 participants