Leverage php-http/discovery v1.15 and decouple from guzzlehttp/psr7 #1459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
auto-discovery
branch
3 times, most recently
from
7a61270 to
4f177b8
Compare
This was referenced Feb 9, 2023
|
Thanks, I'll take a look. |
nicolas-grekas
force-pushed
the
auto-discovery
branch
from
4f177b8 to
a2002d5
Compare
nicolas-grekas
force-pushed
the
auto-discovery
branch
from
73a292a to
785abee
Compare
nicolas-grekas
force-pushed
the
auto-discovery
branch
from
785abee to
ce19c64
Compare
nicolas-grekas
force-pushed
the
auto-discovery
branch
from
ce19c64 to
173928a
Compare
maxhelias
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of #1429
Since this PR and our discussion at SymfonyCon, I've been working on moving those ideas to "php-http/discovery", and v1.15.0 has just been tagged 🎉
By bumping to v1.15.0, we keep compatibility with PHP >= 7.1 and composer v1 & v2, but we also benefit from:
This allows simplifying the dependencies of sentry-php since we can now move guzzlehttp/psr7 from require to require-dev.