option to delete source maps after uploading

[carchrae]

addresses #40

[jan-swiecki]

👍 for this. Much needed feature.

Waiting for merge 🤞

[nspilman]

Thank you for working on this, @carchrae ! Looking forward to this release

[hidde-jan]

@leeandher or anyone else from Sentry, could you have a look at this PR?

[leeandher]

Thanks for the ping @hidde-jan, It looks like reviewing this PR was backlogged soon after I joined the team and just fell through the cracks. I'll resurface this with the team since it seems like a straightforward feature, apologies for the delay!

[carchrae]

i can see a typo in the doc, but aside from that this has been working well for me.

however, one minor thing, perhaps inconsequential, is that the obfuscated source code has a reference to the .map files, so a developer may see a warning that the .map file does not exist. i suppose in the ideal world, you could rebuild the project without source maps or simply remove this reference - but the extra build time/etc did not make that seem worthwhile to me.

[leeandher]

Testing this locally, It worked as expected, but you're right that it results in console warnings.

Source map error: Error: request failed with status 404
Resource URL: https://xxx.netlify.app/_next/static/css/abc123.css
Source Map URL: abc123.css.map

If it's a limitation of the plugin, I think it's worth adding as a foot note to the README

[nathan-knight]

@carchrae are you still interested in working on this? If not I can fork your branch and make the changes that were requested.

[carchrae]

thanks for the reminder @nathan-knight - i'll address these right now

[carchrae]

tested the changes on our deployment, seems ok

[leeandher]

Looks good to me! I'm no longer directly working on the integrations team though, so I will ping @getsentry/ecosystem to merge and release.

[hloehrmann]

Maybe recommend using hidden-source-maps when using deleteSourceMaps so there won't be a broken reference in the obfuscated source.

[nathan-knight]

@leeandher is there any chance you could please ping the integrations team again?

[brianthi]

Hey folks, appreciate the patience with this ticket. I'll prioritize this for the team to run one final round of testing before merge and release. We'll target late December and will update here when ready.

[nathan-knight]

Hey folks, appreciate the patience with this ticket. I'll prioritize this for the team to run one final round of testing before merge and release. We'll target late December and will update here when ready.

Hey I hate to be a bother but my team really needs this feature before we can go live with Sentry in production and this PR has been open since 2021.

[carchrae]

i've been using this since i opened the PR, just follow these steps: #40 (comment)

the only outstanding issue is #50 (review) but that is really only an issue for developers looking at the console. no impact on users, so not a priority for me. you could try the suggestions above to fix that - if you do please report back on clear instructions how to avoid the warning.

all of the change/review requests on this PR have been pretty trivial. i say go ahead and add your own plugin directory to your project and deploy it.

[brianthi]

We're wrapping up a project that came up in December, and someone will be able to pick this up at the beginning of March.

[lobsterkatie]

@carchrae - Thanks for the contribution! I've modified it slightly to use rimraf, since it will handle the recursion for us, and pushed it as #76.

Cheers!