Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Start logger as early as possible #302

Merged
merged 1 commit into from
Jun 17, 2020
Merged

fix: Start logger as early as possible #302

merged 1 commit into from
Jun 17, 2020

Conversation

Swatinem
Copy link
Member

fixes #300

@Swatinem Swatinem requested a review from a team June 17, 2020 08:38
jan-auer
jan-auer reviewed Jun 17, 2020
View reviewed changes
Copy link
Member

@jan-auer jan-auer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change means that SENTRY_WARN no longer works if debug is disabled. Is that intended? We currently do not use SENTRY_WARN, but it could become a surprise in the future.

@Swatinem
Copy link
Member Author

The debug flag enables or suppresses all the logging that sentry does internally. I think someone would have to create their own logger and gate internally on the level, with debug set to true in the options.

@Swatinem Swatinem merged commit 5bff34a into master Jun 17, 2020
@Swatinem Swatinem deleted the fix/early-logging branch June 17, 2020 09:10
irov pushed a commit to irov/sentry-native that referenced this pull request Jun 17, 2020
@Swatinem @irov
fix: Start logger as early as possible (getsentry#302)
19320b9 
fixes getsentry#300
@daxpedda daxpedda mentioned this pull request Jun 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-auer jan-auer jan-auer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing logging in sentry_init
2 participants
@Swatinem @jan-auer